Skip to content

Commit

Permalink
platform/witherspoon: Fix opencapi lane-mask used on GPU0
Browse files Browse the repository at this point in the history
When an opencapi device is used via the Acorn adapter, the link used
is connected to the "middle" group of lanes of the obus. We were using
the wrong set of lanes. The link was somehow still training, likely
because the default settings at power-on were good enough, but it's
still wrong.

Signed-off-by: Frederic Barrat <fbarrat@linux.ibm.com>
Signed-off-by: Stewart Smith <stewart@linux.ibm.com>
  • Loading branch information
fbarrat authored and stewartsmith committed Nov 19, 2018
1 parent 4d28576 commit cdaa6d1
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions platforms/astbmc/witherspoon.c
Original file line number Diff line number Diff line change
Expand Up @@ -300,11 +300,11 @@ static void witherspoon_npu2_device_detect(struct npu2 *npu)
chip->id);
/*
* On witherspoon, bricks 2 and 3 are connected to
* the lanes matching links 1 and 0 in OpenCAPI mode.
* the lanes matching links 0 and 1 in OpenCAPI mode.
*/
set_link_details(npu, 0, 3, NPU2_DEV_TYPE_OPENCAPI);
set_link_details(npu, 1, 3, NPU2_DEV_TYPE_OPENCAPI);
/* We current don't support using the second link */
set_link_details(npu, 1, 2, NPU2_DEV_TYPE_UNKNOWN);
set_link_details(npu, 0, 2, NPU2_DEV_TYPE_UNKNOWN);
} else {
prlog(PR_DEBUG, "PLAT: Chip %d GPU#0 is NVLink\n",
chip->id);
Expand Down

0 comments on commit cdaa6d1

Please sign in to comment.