Skip to content

Commit

Permalink
errorlog: Increase the severity of abnormal reboot events
Browse files Browse the repository at this point in the history
Currently Linux will usually call opal_cec_reboot2() in response to
unrecoverable HMIs and other serious hardware errors. OPAL handles
platform errors by sending an error log to the BMC / FSP and
triggering a software checkstop.

Sending error logs to the BMC / FSP is normally an async operation,
but in this path we need to ensure that error logs are sent out before
the xstop is triggered. The easiest way to do that is to escalate the
severity of the generated error log from "abnormal reboot" to "panic"
since we force panic logs to be send synchronusly. It's also a more
accurate description of what's happening.

CC: Mahesh Salgaonkar <mahesh@linux.vnet.ibm.com>
Signed-off-by: Vasant Hegde <hegdevasant@linux.vnet.ibm.com>
Reviewed-by: Klaus Heinrich Kiwi <klaus@linux.vnet.ibm.com>
[oliver: commit message]
Signed-off-by: Oliver O'Halloran <oohall@gmail.com>
  • Loading branch information
Vasant Hegde authored and oohal committed Mar 11, 2020
1 parent 033e797 commit daf9215
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion core/platform.c
Expand Up @@ -27,7 +27,7 @@ bool manufacturing_mode = false;
struct platform platform;

DEFINE_LOG_ENTRY(OPAL_RC_ABNORMAL_REBOOT, OPAL_PLATFORM_ERR_EVT, OPAL_CEC,
OPAL_CEC_HARDWARE, OPAL_PREDICTIVE_ERR_FAULT_RECTIFY_REBOOT,
OPAL_CEC_HARDWARE, OPAL_ERROR_PANIC,
OPAL_ABNORMAL_POWER_OFF);

/*
Expand Down

0 comments on commit daf9215

Please sign in to comment.