Skip to content

Commit

Permalink
xive: fix opal_xive_set_vp_info() error path
Browse files Browse the repository at this point in the history
In case of error, opal_xive_set_vp_info() will return without
unlocking the xive object. This is most certainly a typo.

Signed-off-by: Cédric Le Goater <clg@kaod.org>
Acked-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
  • Loading branch information
legoater authored and stewartsmith committed Mar 23, 2018
1 parent 87145c6 commit dcbf18c
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion hw/xive.c
Original file line number Diff line number Diff line change
Expand Up @@ -4421,8 +4421,8 @@ static int64_t opal_xive_set_vp_info(uint64_t vp_id,
if (!(flags & OPAL_XIVE_VP_ENABLED))
xive_vpc_scrub_clean(x, blk, idx);

unlock(&x->lock);
bail:
unlock(&x->lock);
return rc;
}

Expand Down

0 comments on commit dcbf18c

Please sign in to comment.