Skip to content

Commit

Permalink
hdata: Fix dtc warnings
Browse files Browse the repository at this point in the history
Fix dtc warnings related to mcbist node.

Warning (reg_format): "reg" property in /xscom@623fc00000000/mcbist@1 has invalid length (4 bytes) (#address-cells == 1, #size-cells == 1)
Warning (reg_format): "reg" property in /xscom@623fc00000000/mcbist@2 has invalid length (4 bytes) (#address-cells == 1, #size-cells == 1)
Warning (reg_format): "reg" property in /xscom@603fc00000000/mcbist@1 has invalid length (4 bytes) (#address-cells == 1, #size-cells == 1)
Warning (reg_format): "reg" property in /xscom@603fc00000000/mcbist@2 has invalid length (4 bytes) (#address-cells == 1, #size-cells == 1)

Ideally we should add proper xscom range here... but we are not getting that
information in HDAT today. Lets fix warning until we get proper data in HDAT.

Signed-off-by: Vasant Hegde <hegdevasant@linux.vnet.ibm.com>
Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
  • Loading branch information
Vasant Hegde authored and stewartsmith committed Sep 13, 2018
1 parent df5da05 commit dd2dacf
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion hdata/memory.c
Original file line number Diff line number Diff line change
Expand Up @@ -448,7 +448,9 @@ static void add_memory_controller(const struct HDIF_common_hdr *msarea,
if (!mcbist) {
mcbist = dt_new_addr(xscom, "mcbist", mcbist_id);
assert(mcbist);
dt_add_mem_reg_property(mcbist, mcbist_id);
dt_add_property_cells(mcbist, "#address-cells", 1);
dt_add_property_cells(mcbist, "#size-cells", 0);
dt_add_property_cells(mcbist, "reg", mcbist_id, 0);
}

mcs_id = MS_CONTROLLER_MCS_ID(controller_id);
Expand Down

0 comments on commit dd2dacf

Please sign in to comment.