Skip to content

Commit

Permalink
phb4: Do more retries on link training failures
Browse files Browse the repository at this point in the history
Currently we only retry once when we have a link training failure.

This changes this to be 3 retries as 1 retry is not giving us enough
reliablity.

This will increase the boot time, especially on systems where we
incorrectly detect a link presence when there really is nothing
present. I'll post a followup patch to optimise our timings to help
mitigate this later.

Signed-off-by: Michael Neuling <mikey@neuling.org>
Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
  • Loading branch information
mikey authored and stewartsmith committed Jul 13, 2017
1 parent 652340a commit de36049
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion hw/phb4.c
Original file line number Diff line number Diff line change
Expand Up @@ -2512,7 +2512,7 @@ static struct pci_slot *phb4_slot_create(struct phb *phb)
slot->ops.hreset = phb4_hreset;
slot->ops.freset = phb4_freset;
slot->ops.creset = phb4_creset;
slot->link_retries = 1;
slot->link_retries = 3;

return slot;
}
Expand Down

0 comments on commit de36049

Please sign in to comment.