Skip to content

Commit

Permalink
phb4: Quieten and improve "Timeout waiting for electrical link"
Browse files Browse the repository at this point in the history
This happens normally if a slot doesn't have a working HW presence
detect and relies instead of inband presence detect.

The message we display is scary and not very useful unless ou
are debugging, so quiten it up and change it to something more
meaningful.

Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Acked-By: Michael Neuling <mikey@neuling.org>
Signed-off-by: Stewart Smith <stewart@linux.ibm.com>
  • Loading branch information
ozbenh authored and stewartsmith committed Apr 10, 2018
1 parent bca7c02 commit e6bca4a
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions hw/phb4.c
Original file line number Diff line number Diff line change
Expand Up @@ -2641,9 +2641,8 @@ static int64_t phb4_poll_link(struct pci_slot *slot)
}

if (slot->retries-- == 0) {
PHBERR(p, "LINK: Timeout waiting for electrical link\n");
PHBDBG(p, "LINK: DLP train control: 0x%016llx\n", reg);
return OPAL_HARDWARE;
PHBDBG(p, "LINK: No in-band presence\n");
return OPAL_SUCCESS;
}
/* Retry */
return pci_slot_set_sm_timeout(slot, msecs_to_tb(10));
Expand Down

0 comments on commit e6bca4a

Please sign in to comment.