Skip to content

Commit

Permalink
AMI BMC: use 0x3a as OEM command
Browse files Browse the repository at this point in the history
[ Upstream commit e922775 ]

The 0x3a OEM command is for IBM commands, while 0x32 was for AMI ones.
Sometime in the P8 timeframe, AMI BMCs were changed to listen for our
commands on either 0x32 or 0x3a. Since 0x3a is the direction forward,
we'll use that, as P9 machines with AMI BMCs probably also want these
to work, and let's not bet that 0x32 will continue to be okay.

Suggested-by: Joseph Reynolds <jrey@us.ibm.com>
Suggested-by: Maury Zipse <zipse@us.ibm.com>
Signed-off-by: Stewart Smith <stewart@linux.ibm.com>
  • Loading branch information
stewartsmith committed Oct 24, 2018
1 parent fbe074c commit fd4bbc8
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion platforms/astbmc/common.c
Original file line number Diff line number Diff line change
Expand Up @@ -423,7 +423,7 @@ void astbmc_early_init(void)

const struct bmc_platform astbmc_ami = {
.name = "AMI",
.ipmi_oem_partial_add_esel = IPMI_CODE(0x32, 0xf0),
.ipmi_oem_partial_add_esel = IPMI_CODE(0x3a, 0xf0),
.ipmi_oem_pnor_access_status = IPMI_CODE(0x3a, 0x07),
};

Expand Down

0 comments on commit fd4bbc8

Please sign in to comment.