Fixed macro ifdefs to enable building without openssl. #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dstebila
approved these changes
Feb 1, 2019
|
oqs_openssh.sh integration tests pass on macOS. (Admittedly, they don't exercise the problem that prompted this, but at least the change didn't break the normal case. Do you think we should add the command-line you listed above to the integration tests to ensure no regressions?) |
|
Perhaps; I tumbled on this issue by trying to build the project without openssl because my machine didn't have an old-enough version of openssl. I'm not a 100% sure of the implications of building without openssl and if this is even recommended in a real deployment (vs. dev environment). I'll open the issue to investigate if this should be added to our integration tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The OQS fork was not building when compiling the project without openssl:
./configure --enable-pq-kex --enable-hybrid-kex --without-openssl --prefix=<path_to_openssh> --sysconfdir=<path_to_openssh> --with-liboqs-dir=<path_to_oqs>I added some ifdef macros in the OQS-related hybrid code that also needed openssl.