Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistency in hybrid signature algorithm names #124

Closed
dstebila opened this issue Oct 16, 2019 · 2 comments
Closed

Inconsistency in hybrid signature algorithm names #124

dstebila opened this issue Oct 16, 2019 · 2 comments
Assignees
Labels
bug Something isn't working OpenSSL-111 Changes specific to OQS-OpenSSL_1_1_1-stable branch

Comments

@dstebila
Copy link
Member

In the C source code e.g. https://github.com/open-quantum-safe/openssl/blob/OQS-OpenSSL_1_1_1-stable/crypto/objects/obj_dat.h#L5798 hybrid signature algorithms have an underscore e.g. p256_oqsdefault.

But in the test harness https://github.com/open-quantum-safe/openssl/blob/OQS-OpenSSL_1_1_1-stable/oqs_test/tests/test_openssl.py#L23 and in README.md, the hybrid signature algorithms have a hyphen e.g. p256-oqsdefault.

Does this mean that they are not running correctly?

Observed by Michael Baentsch.

@dstebila dstebila added question Further information is requested OpenSSL-111 Changes specific to OQS-OpenSSL_1_1_1-stable branch labels Oct 16, 2019
@zrlmib
Copy link

zrlmib commented Oct 17, 2019

FWIW, additional comment: This becomes visible when changing line 76 in https://github.com/open-quantum-safe/openssl/blob/OQS-OpenSSL_1_1_1-stable/oqs_test/tests/test_openssl.py
from
else: sig_alg_sized = "rsa"
to read
else: sig_alg_sized = sig_alg
(which arguably is better as then sig algs other than ECDSA and RSA get tested).

@xvzcf
Copy link

xvzcf commented Oct 18, 2019

Indeed, the hybrid signature algorithms were not being tested. This should fix it.

@xvzcf xvzcf added bug Something isn't working and removed question Further information is requested labels Oct 21, 2019
@xvzcf xvzcf closed this as completed Oct 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working OpenSSL-111 Changes specific to OQS-OpenSSL_1_1_1-stable branch
Projects
None yet
Development

No branches or pull requests

3 participants