Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qsc_encodings silently failing #129

Closed
baentsch opened this issue Mar 25, 2023 · 1 comment · Fixed by #131
Closed

qsc_encodings silently failing #129

baentsch opened this issue Mar 25, 2023 · 1 comment · Fixed by #131

Comments

@baentsch
Copy link
Member

baentsch commented Mar 25, 2023 •
edited
Loading

Describe the bug
The CI tests show error messages like "Could not create OQS signature encoding algorithm draft-uni-qsckeys-falcon-00/sk-pk (Falcon-512, 1.3.9999.3.6). Defaulting to no encoding."

To Reproduce
See for example https://app.circleci.com/pipelines/github/open-quantum-safe/oqs-provider/410/workflows/a97aa465-7023-4479-89e0-844fcb926e7f/jobs/431 (scroll to last test sequence and check logfiles).

Expected behavior
The tests should fail and not pass -- otherwise they don't have value, right @bhess?

Environment (please complete the following information):
CircleCI

Update/add: I cannot reproduce this behaviour locally, so here's at least a screenshot:
grafik
@bhess bhess mentioned this issue Mar 25, 2023
Merged
@bhess
Copy link
Member

bhess commented Mar 25, 2023

I agree, the tests should fail. I created a fix in PR #131. Thanks for noticing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@bhess @baentsch