Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x448, x25519 hybrids not working #36

Closed
baentsch opened this issue Oct 23, 2021 · 1 comment · Fixed by #37
Closed

x448, x25519 hybrids not working #36

baentsch opened this issue Oct 23, 2021 · 1 comment · Fixed by #37

Comments

@baentsch
Copy link
Member

@bhess: These hybrids somehow (probably due to upstream code fix) don't pass testing any more. Please let me know if you have time to look into this or whether I should temporarily disable those hybrids, or should dig deeper.

For reference: OK test when doing OSSL3.0 release vs Failed test from today (simple CCI re-run without code change).
baentsch referenced this issue Oct 23, 2021
@bhess
Update to ensure hybrid kex interop, updates for OpenSSL master (#24)
a8c001e 
* Rename OSSL_PROVIDER_get0_name after openssl/openssl#15405

* Reverts workaround after bugfix in OpenSSL upstream (i2d_PrivateKey return value was incorrect)

Adds oqs_kem_default

Hybrid KEX is chosen according to bit_security defined in generate.yml, fixes inconsistenties between claimed_security_level and bit_security.
@bhess
Copy link
Member

bhess commented Oct 23, 2021 •
edited
Loading

Thank you for already narrowing down the bug. The tests fail since the following change in OpenSSL.

openssl/openssl@43da9a1#diff-7be17a378707cd24bee6dd38b4f7da3b702397cf75364305fe31bdde486fb998L532-L538

@bhess bhess mentioned this issue Oct 23, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Corrects use of OpenSSL EVP_PKEY_get_raw_private_key API open-quantum-safe/oqs-provider
2 participants
@bhess @baentsch