Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Ruby's send SMS with Twillio docs #107

Merged
merged 3 commits into from Dec 20, 2022

Conversation

fagiani
Copy link
Contributor

@fagiani fagiani commented Oct 21, 2022

This commit fixes copy issues:

  • Some places where it should read Ruby and instead was Python
  • An incorrect path
  • A place where it should read with and instead was without
  • There was a warning pointing to replace a value that was set with another name

This commit fixes copy issues:
- Some places where it should read Ruby and instead was Python
- An incorrect path
- A place where it should read with and instead was without
- There was a warning pointing to replace a value that was set with another name
Copy link
Member

@adityaoberai adityaoberai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixes @fagiani
Just a couple of minor changes that need to be made and then this should be good to go 👍

ruby/send-sms-with-twilio/README.md Outdated Show resolved Hide resolved
ruby/send-sms-with-twilio/README.md Outdated Show resolved Hide resolved
@PineappleIOnic
Copy link
Contributor

Thank you so much for the PR 🤩. We're adding the hacktoberfest-accepted label to ensure this PR counts towards your Hacktoberfest contributions count. With that said, please stay active on this PR to address any comments once you receive a review. Happy Hacktoberfest! 🎃

fagiani and others added 2 commits October 31, 2022 16:00
Co-authored-by: Aditya Oberai <adityaoberai1@gmail.com>
Co-authored-by: Aditya Oberai <adityaoberai1@gmail.com>
Copy link
Member

@adityaoberai adityaoberai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@christyjacob4 christyjacob4 merged commit 9792013 into open-runtimes:main Dec 20, 2022
@christyjacob4
Copy link
Contributor

THANK YOU! All changes merged 🥳

Please reach out to me on our Discord server if you would like to claim your Appwrite swags! As a way of saying thank you, we would also love to invite you to join the Appwrite organization on GitHub. Please share your GitHub username with us on Discord.  

You can accept the invite by visiting https://github.com/orgs/appwrite/invitation. By joining our team, you will officially be an Appwrite maintainer on GitHub.

You can change your membership visibility settings, so your new Appwrite team membership badge will show up on your personal GitHub profile.

Please feel free to look for more PRs you might be interested in helping with on our long list of Hacktoberfest friendly issues and help make Appwrite better :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants