New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat-4176-send-http-request #38
feat-4176-send-http-request #38
Conversation
* created function to send http request * added guzzle client dependency * added vendor to gitignore * added redme file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Yordaniss Great PR! 🤯 We left some comments during the review, please check them out.
* adjusted readme file * added return if some errors occure * added checks to provide right response message
@stnguyen90 thanks a lot for feedback. 🙏 I did all requested changes and also added some new checks to avoid warning messages and improve response. If some extra changes required please let me know 😊 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work on your PR! We've approved your work and it'll be merged soon!
* return status code from response, not always 200 if response is ok
THANK YOU! All changes merged 🥳 Please reach out to me on our Discord server if you would like to claim your Appwrite swags! As a way of saying thank you, we would also love to invite you to join the Appwrite organization on GitHub. Please share your GitHub username with us on Discord. You can accept the invite by visiting https://github.com/orgs/appwrite/invitation. By joining our team, you will officially be an Appwrite maintainer on GitHub. You can change your membership visibility settings, so your new Appwrite team membership badge will show up on your personal GitHub profile. Please feel free to look for more PRs you might be interested in helping with on our long list of Hacktoberfest friendly issues and help make Appwrite better :) |
Issue #4176 write a sendHTTPRequest() function using PHP
Closes appwrite/appwrite#4176
Successful response:
Error response: