Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat-4176-send-http-request #38

Merged

Conversation

Yordaniss
Copy link
Contributor

@Yordaniss Yordaniss commented Oct 4, 2022

Issue #4176 write a sendHTTPRequest() function using PHP

Closes appwrite/appwrite#4176

  • created function to send http request
  • added guzzle client dependency
  • added vendor to gitignore
  • added readme file

Successful response:
Bildschirmfoto 2022-10-04 um 21 04 15

Error response:
Bildschirmfoto 2022-10-04 um 21 04 52

* created function to send http request
* added guzzle client dependency
* added vendor to gitignore
* added redme file
Copy link
Contributor

@stnguyen90 stnguyen90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Yordaniss Great PR! 🤯 We left some comments during the review, please check them out.

php/send-http-request/README.md Outdated Show resolved Hide resolved
php/send-http-request/README.md Outdated Show resolved Hide resolved
php/send-http-request/index.php Show resolved Hide resolved
php/send-http-request/index.php Outdated Show resolved Hide resolved
php/send-http-request/index.php Outdated Show resolved Hide resolved
* adjusted readme file
* added return if some errors occure
* added checks to provide right response message
@Yordaniss
Copy link
Contributor Author

@stnguyen90 thanks a lot for feedback. 🙏 I did all requested changes and also added some new checks to avoid warning messages and improve response. If some extra changes required please let me know 😊

@stnguyen90 stnguyen90 self-requested a review October 25, 2022 20:10
Copy link
Contributor

@stnguyen90 stnguyen90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work on your PR! We've approved your work and it'll be merged soon!

* return status code from response, not always 200 if response is ok
@christyjacob4 christyjacob4 merged commit f0d4e1e into open-runtimes:main Dec 20, 2022
@christyjacob4
Copy link
Contributor

THANK YOU! All changes merged 🥳

Please reach out to me on our Discord server if you would like to claim your Appwrite swags! As a way of saying thank you, we would also love to invite you to join the Appwrite organization on GitHub. Please share your GitHub username with us on Discord.  

You can accept the invite by visiting https://github.com/orgs/appwrite/invitation. By joining our team, you will officially be an Appwrite maintainer on GitHub.

You can change your membership visibility settings, so your new Appwrite team membership badge will show up on your personal GitHub profile.

Please feel free to look for more PRs you might be interested in helping with on our long list of Hacktoberfest friendly issues and help make Appwrite better :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

⚡ Write a sendHTTPRequest() Function using PHP
3 participants