fix: Updated RepoChecker to allow all types of repos #202

punyamsingh · 2023-07-05T21:53:18Z

What type of PR is this? (check all applicable)

Description

Update the regular expression in isGithubRepoPage function in urlMatchers.ts to include an optional trailing slash in the GitHub repository URL. This allows URLs with or without a trailing slash to be recognized as GitHub repository pages.

Related Tickets & Documents

#176

Mobile & Desktop Screenshots/Recordings

Added tests?

👍 yes
🙅 no, because they aren't needed
🙋 no, because I need help

Added to documentation?

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

submitting for review

Co-authored-by: Brian Douglas <bdougie@users.noreply.github.com>

(i hate lint)

github-actions

PR Compliance Checks

Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.

Issue Reference

In order to be considered for merging, the pull request description must refer to a specific issue number. This is described in our Contributing Guide.
This check is looking for a phrase similar to: "Fixes #XYZ" or "Resolves #XYZ" where XYZ is the issue number that this PR is meant to address.

Protected Branch

In order to be considered for merging, the pull request changes must not be implemented on the "beta" branch. This is described in our Contributing Guide. We would suggest that you close this PR and implement your changes as described in our Contributing Guide and open a new pull request.

diivi · 2023-07-06T05:59:33Z

The change looks good, but you should probably give this a read - https://docs.github.com/en/get-started/quickstart/github-flow.

You should keep your beta branch up to date, check out feature branches from that branch, and then open pull requests. This will help you work on multiple stuff, keep your commit history clean and is best practice.

Anyway, we squash commits so it doesn't matter in this case, but good to keep in mind for later!

bdougie · 2023-07-07T23:03:00Z

Need to rebase beta. I believe the failing check is now fixed there.

bdougie · 2023-07-10T23:34:21Z

Need to rebase beta. I believe the failing check is now fixed there.

Checking again. Can you run the following

git fetch
git rebase origin/beta

punyamsingh · 2023-07-11T08:43:17Z

uh, sorry for being unavailable. i don't have my laptop with me right now. I'll get to this tomorrow.

punyamsingh · 2023-07-11T15:18:49Z

its working now @bdougie
please check

bdougie

Thanks for rebasing

## [1.10.0-beta.3](v1.10.0-beta.2...v1.10.0-beta.3) (2023-07-11) ### 🐛 Bug Fixes * Rename project-utilities.md to 3-project-utilities.md ([d0a6702](d0a6702)) * Updated RepoChecker to allow all types of repos ([#202](#202)) ([2161918](2161918)), closes [issue#112](https://github.com/open-sauced/issue/issues/112) [issue#112](https://github.com/open-sauced/issue/issues/112)

github-actions · 2023-07-11T20:57:50Z

🎉 This PR is included in version 1.10.0-beta.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

## [1.10.0](v1.9.0...v1.10.0) (2023-07-12) ### 🍕 Features * Cherry pick susmita ([#204](#204)) ([7458724](7458724)) * react/unreact on highlights ([#200](#200)) ([c65eca0](c65eca0)) ### 🐛 Bug Fixes * Create issue-metrics.yml ([4a6c19d](4a6c19d)) * Rename project-utilities.md to 3-project-utilities.md ([d0a6702](d0a6702)) * Updated RepoChecker to allow all types of repos ([#202](#202)) ([2161918](2161918)), closes [issue#112](https://github.com/open-sauced/issue/issues/112) [issue#112](https://github.com/open-sauced/issue/issues/112)

github-actions · 2023-07-12T13:57:10Z

🎉 This PR is included in version 1.10.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

## [1.10.0-beta.3](open-sauced/ai@v1.10.0-beta.2...v1.10.0-beta.3) (2023-07-11) ### 🐛 Bug Fixes * Rename project-utilities.md to 3-project-utilities.md ([d0a6702](open-sauced/ai@d0a6702)) * Updated RepoChecker to allow all types of repos ([#202](open-sauced/ai#202)) ([2161918](open-sauced/ai@2161918)), closes [issue#112](https://github.com/open-sauced/issue/issues/112) [issue#112](https://github.com/open-sauced/issue/issues/112)

## [1.10.0](open-sauced/ai@v1.9.0...v1.10.0) (2023-07-12) ### 🍕 Features * Cherry pick susmita ([#204](open-sauced/ai#204)) ([7458724](open-sauced/ai@7458724)) * react/unreact on highlights ([#200](open-sauced/ai#200)) ([c65eca0](open-sauced/ai@c65eca0)) ### 🐛 Bug Fixes * Create issue-metrics.yml ([4a6c19d](open-sauced/ai@4a6c19d)) * Rename project-utilities.md to 3-project-utilities.md ([d0a6702](open-sauced/ai@d0a6702)) * Updated RepoChecker to allow all types of repos ([#202](open-sauced/ai#202)) ([2161918](open-sauced/ai@2161918)), closes [issue#112](https://github.com/open-sauced/issue/issues/112) [issue#112](https://github.com/open-sauced/issue/issues/112)

punyamsingh and others added 21 commits June 14, 2023 21:19

issue#112 resolved. submitting for review

e1020ea

issue#112 resolved.

d37fb72

submitting for review

profile.tsx added line 59

ef38dd8

shifted the function & interface to dateUtils.ts

6705535

shited the function to getContributedRepos.ts

eb19ed4

Update src/popup/pages/profile.tsx

e6b2687

Co-authored-by: Brian Douglas <bdougie@users.noreply.github.com>

Update src/utils/getContributedRepos.ts

35c1d60

Co-authored-by: Brian Douglas <bdougie@users.noreply.github.com>

Update src/utils/getContributedRepos.ts

b9a1264

Co-authored-by: Brian Douglas <bdougie@users.noreply.github.com>

Update src/utils/getContributedRepos.ts

2fecf46

Co-authored-by: Brian Douglas <bdougie@users.noreply.github.com>

Update src/popup/pages/profile.tsx

afefa93

Co-authored-by: Brian Douglas <bdougie@users.noreply.github.com>

Update src/utils/getContributedRepos.ts

8c6ec1c

Co-authored-by: Brian Douglas <bdougie@users.noreply.github.com>

removed eslint from the loop

480ed41

add semicolon to pass lint check

154156c

Merge branch 'open-sauced:beta' into beta

25eadeb

Merge branch 'open-sauced:beta' into beta

005d5a6

made the Tools conditional

3d2abfc

added trailing comma to home.txt 37 35

760cb24

ran "npm run format"

9ecdced

(i hate lint)

added useRef and made suitable changes

f50465c

Merge branch 'open-sauced:beta' into beta

375235b

removed the dollar sign

d1a9496

github-actions bot reviewed Jul 5, 2023

View reviewed changes

punyamsingh changed the title ~~Removed the unnecessary $ sign in the RepoChecker~~ fix: Removed the unnecessary $ sign in the RepoChecker Jul 5, 2023

Changed github repo pattern

c9db8ad

punyamsingh changed the title ~~fix: Removed the unnecessary $ sign in the RepoChecker~~ fix: Updated RepoChecker Jul 5, 2023

punyamsingh changed the title ~~fix: Updated RepoChecker~~ fix: Updated RepoChecker to allow all types of repos Jul 8, 2023

punyamsingh added 2 commits July 11, 2023 20:27

Merge branch 'open-sauced:beta' into beta

a9ac129

changes the urlmatcherstest file

a7934bb

bdougie approved these changes Jul 11, 2023

View reviewed changes

bdougie merged commit 2161918 into open-sauced:beta Jul 11, 2023
6 checks passed

github-actions bot added the released on @beta label Jul 11, 2023

bdougie mentioned this pull request Jul 12, 2023

main <- v1.10.0-beta.3 #205

Merged

github-actions bot added the released label Jul 12, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Updated RepoChecker to allow all types of repos #202

fix: Updated RepoChecker to allow all types of repos #202

punyamsingh commented Jul 5, 2023 •

edited

github-actions bot left a comment •

edited

diivi commented Jul 6, 2023 •

edited

bdougie commented Jul 7, 2023

bdougie commented Jul 10, 2023

punyamsingh commented Jul 11, 2023

punyamsingh commented Jul 11, 2023

bdougie left a comment

github-actions bot commented Jul 11, 2023

github-actions bot commented Jul 12, 2023

fix: Updated RepoChecker to allow all types of repos #202

fix: Updated RepoChecker to allow all types of repos #202

Conversation

punyamsingh commented Jul 5, 2023 • edited

What type of PR is this? (check all applicable)

Description

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings

Added tests?

Added to documentation?

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

github-actions bot left a comment • edited

Choose a reason for hiding this comment

PR Compliance Checks

Issue Reference

Protected Branch

diivi commented Jul 6, 2023 • edited

bdougie commented Jul 7, 2023

bdougie commented Jul 10, 2023

punyamsingh commented Jul 11, 2023

punyamsingh commented Jul 11, 2023

bdougie left a comment

Choose a reason for hiding this comment

github-actions bot commented Jul 11, 2023

github-actions bot commented Jul 12, 2023

punyamsingh commented Jul 5, 2023 •

edited

github-actions bot left a comment •

edited

diivi commented Jul 6, 2023 •

edited