Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: updated link #245

Merged
merged 3 commits into from
Aug 15, 2023
Merged

fix: updated link #245

merged 3 commits into from
Aug 15, 2023

Conversation

CBID2
Copy link
Contributor

@CBID2 CBID2 commented Aug 10, 2023

Description

This PR updates the AddPRToHighlightsButton component in the AddPRToHighlightsButton.ts file.

  • The code has been formatted for better readability.
  • The onclick event handler has been updated to toggle the visibility of the dropdown menu.
  • The addEventListener for the click event has been added to hide the dropdown menu when clicking outside of it.

These changes improve the functionality and user experience of the AddPRToHighlightsButton component.

What type of PR is this? (check all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🎨 Style
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build
  • 🔁 CI
  • 📦 Chore (Release)
  • ⏩ Revert

Related Tickets & Documents

Fixes #242

Mobile & Desktop Screenshots/Recordings

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help

Added to documentation?

  • 📜 README.md
  • 📓 docs.opensauced.pizza
  • 🍕 dev.to/opensauced
  • 📕 storybook
  • 🙅 no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

image

github-actions[bot]
github-actions bot reviewed Aug 10, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks Passed!

@CBID2 CBID2 self-assigned this Aug 10, 2023
@CBID2 CBID2 added help wanted Extra attention is needed 🐛 bug Something isn't working labels Aug 10, 2023
@CBID2
Copy link
Contributor Author

CBID2 commented Aug 10, 2023 •
edited

Hey @Anush008 and @bdougie. Everything's ok except for the third test. I tried doing the fix command to format the code better. Even though I installed eslint, I get this error in my terminal:
command does not exist

@bdougie
Copy link
Member

bdougie commented Aug 10, 2023

@CBID2 need to run npm run format locally to handle the lint errors. FYI, the image you shared seems wrong and unrelate.

@CBID2
Copy link
Contributor Author

CBID2 commented Aug 10, 2023

Ohh ok

@CBID2
Copy link
Contributor Author

CBID2 commented Aug 10, 2023

npm run format

@CBID2 need to run npm run format locally to handle the lint errors. FYI, the image you shared seems wrong and unrelate.

It worked @bdougie

@CBID2 CBID2 requested a review from bdougie August 10, 2023 03:51
bdougie
bdougie requested changes Aug 10, 2023
View reviewed changes
Copy link
Member

@bdougie bdougie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment for what is expected.

@CBID2 @bdougie
Update src/content-scripts/components/AddPRToHighlights/AddPRToHighli…
5642f51 
…ghtsButton.ts

Co-authored-by: Brian Douglas <bdougie@users.noreply.github.com>
@CBID2
Copy link
Contributor Author

CBID2 commented Aug 11, 2023

Did it @bdougie

@CBID2 CBID2 mentioned this pull request Aug 15, 2023
Closed
@bdougie bdougie merged commit fe1a58b into open-sauced:beta Aug 15, 2023
6 checks passed
github-actions bot pushed a commit that referenced this pull request Aug 15, 2023
@CBID2 @open-sauced
chore(patch): release 1.14.0-beta.2 on beta channel [skip ci]
4edc6ca 
## [1.14.0-beta.2](v1.14.0-beta.1...v1.14.0-beta.2) (2023-08-15)

### 🐛 Bug Fixes

* updated link ([#245](#245)) ([fe1a58b](fe1a58b))
@github-actions
Copy link

🎉 This PR is included in version 1.14.0-beta.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@CBID2 CBID2 deleted the fixing-highlight-bug branch August 15, 2023 17:10
github-actions bot pushed a commit that referenced this pull request Aug 15, 2023
@bdougie @open-sauced
chore(minor): release 1.14.0 [skip ci]
2f8617f 
## [1.14.0](v1.13.0...v1.14.0) (2023-08-15)

### 🍕 Features

* modify suggested queries ([#251](#251)) ([d3ac35a](d3ac35a))

### 🐛 Bug Fixes

* incorrect embedding status, regex security warnings ([#253](#253)) ([34f66b1](34f66b1))
* updated link ([#245](#245)) ([fe1a58b](fe1a58b))
@github-actions
Copy link

🎉 This PR is included in version 1.14.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions left review comments

@bdougie bdougie bdougie approved these changes

Assignees

@CBID2 CBID2

Labels
🐛 bug Something isn't working help wanted Extra attention is needed released on @beta released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: PR does not automatically go to Highlights
2 participants
@CBID2 @bdougie