Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add endpoint to retrieve insight page by id #58

Merged
merged 4 commits into from Nov 10, 2022

Conversation

brandonroberts
Copy link
Contributor

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation Update
  • 🎨 Style
  • πŸ§‘β€πŸ’» Code Refactor
  • πŸ”₯ Performance Improvements
  • βœ… Test
  • πŸ€– Build
  • πŸ” CI
  • πŸ“¦ Chore (Release)
  • ⏩ Revert

Description

This PR

  • Adds a new endpoint to retrieve a insight page using its id
  • Fixes saving a new insight page after creation
  • Moves original insights.controller to user-insights.controller

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings

Added tests?

  • πŸ‘ yes
  • πŸ™… no, because they aren't needed
  • πŸ™‹ no, because I need help

Added to documentation?

  • πŸ“œ README.md
  • πŸ““ docs.opensauced.pizza
  • πŸ• dev.to/opensauced
  • πŸ“• storybook
  • πŸ™… no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

Also fixes saving a new insight page
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks

Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.

Issue Reference

In order to be considered for merging, the pull request description must refer to a specific issue number. This is described in our Contributing Guide.
This check is looking for a phrase similar to: "Fixes #XYZ" or "Resolves #XYZ" where XYZ is the issue number that this PR is meant to address.

Copy link
Contributor

@0-vortex 0-vortex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! πŸ‘

One minor change, the other is more like a remember pin πŸ˜…

src/insight/insights.service.ts Outdated Show resolved Hide resolved
src/insight/insights.service.ts Show resolved Hide resolved
@brandonroberts brandonroberts merged commit 648dbeb into beta Nov 10, 2022
@brandonroberts brandonroberts deleted the feat-get-insight-page branch November 10, 2022 18:10
github-actions bot pushed a commit that referenced this pull request Nov 10, 2022
## [1.17.0-beta.3](v1.17.0-beta.2...v1.17.0-beta.3) (2022-11-10)

### πŸ• Features

* add endpoint to retrieve insight page by id ([#58](#58)) ([648dbeb](648dbeb))
@github-actions
Copy link

πŸŽ‰ This PR is included in version 1.17.0-beta.3 πŸŽ‰

The release is available on:

Your semantic-release bot πŸ“¦πŸš€

github-actions bot pushed a commit that referenced this pull request Nov 11, 2022
## [1.17.0](v1.16.0...v1.17.0) (2022-11-11)

### πŸ› Bug Fixes

* correct database loading backfill not saving user ([7cfc04b](7cfc04b))

### πŸ• Features

* add associating users to repositories to onboarding endpoint ([#57](#57)) ([cda2cb2](cda2cb2))
* add endpoint to retrieve insight page by id ([#58](#58)) ([648dbeb](648dbeb))
@github-actions
Copy link

πŸŽ‰ This PR is included in version 1.17.0 πŸŽ‰

The release is available on:

Your semantic-release bot πŸ“¦πŸš€

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants