Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add endpoints to update/remove insight page #68

Merged
merged 2 commits into from Nov 22, 2022

Conversation

brandonroberts
Copy link
Contributor

@brandonroberts brandonroberts commented Nov 21, 2022

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation Update
  • 🎨 Style
  • πŸ§‘β€πŸ’» Code Refactor
  • πŸ”₯ Performance Improvements
  • βœ… Test
  • πŸ€– Build
  • πŸ” CI
  • πŸ“¦ Chore (Release)
  • ⏩ Revert

Description

This PR:

  • Adds endpoints to update an insight page and its associated repos
  • Remove an insight page by soft deletion

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings

Added tests?

  • πŸ‘ yes
  • πŸ™… no, because they aren't needed
  • πŸ™‹ no, because I need help

Added to documentation?

  • πŸ“œ README.md
  • πŸ““ docs.opensauced.pizza
  • πŸ• dev.to/opensauced
  • πŸ“• storybook
  • πŸ™… no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks

Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.

Issue Reference

In order to be considered for merging, the pull request description must refer to a specific issue number. This is described in our Contributing Guide.
This check is looking for a phrase similar to: "Fixes #XYZ" or "Resolves #XYZ" where XYZ is the issue number that this PR is meant to address.

Copy link
Contributor

@0-vortex 0-vortex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! πŸ‘

Added one small improvement but I'm biased about whether it's super needed right now.

src/insight/user-insight.controller.ts Outdated Show resolved Hide resolved
@brandonroberts brandonroberts merged commit df56c4f into beta Nov 22, 2022
@brandonroberts brandonroberts deleted the feat-update-remove-insight branch November 22, 2022 14:56
github-actions bot pushed a commit that referenced this pull request Nov 22, 2022
## [1.19.0-beta.1](v1.18.1-beta.1...v1.19.0-beta.1) (2022-11-22)

### πŸ• Features

* add endpoints to update/remove insight page ([#68](#68)) ([df56c4f](df56c4f))
@github-actions
Copy link

πŸŽ‰ This PR is included in version 1.19.0-beta.1 πŸŽ‰

The release is available on:

Your semantic-release bot πŸ“¦πŸš€

github-actions bot pushed a commit that referenced this pull request Nov 29, 2022
## [1.19.0](v1.18.1...v1.19.0) (2022-11-29)

### πŸ• Features

* add endpoints to update/remove insight page ([#68](#68)) ([df56c4f](df56c4f))
@github-actions
Copy link

πŸŽ‰ This PR is included in version 1.19.0 πŸŽ‰

The release is available on:

Your semantic-release bot πŸ“¦πŸš€

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants