Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Front-End] Implement Dropdown Menu #20

Closed
Tracked by #4
chadstewart opened this issue Jul 8, 2022 · 8 comments 路 Fixed by #95
Closed
Tracked by #4

[Front-End] Implement Dropdown Menu #20

chadstewart opened this issue Jul 8, 2022 · 8 comments 路 Fixed by #95

Comments

@chadstewart
Copy link
Contributor

No description provided.

@pixelsbyeryc pixelsbyeryc added the needs design Front-end tasks that are missing a design. Create a new issue for the design. label Jul 9, 2022
@pixelsbyeryc
Copy link
Contributor

We have to define what's going to be under the Dropdown Menu... Is it only "Log out"? @chadstewart @bdougie

@chadstewart
Copy link
Contributor Author

We have to define what's going to be under the Dropdown Menu... Is it only "Log out"? @chadstewart @bdougie

So right now, I think just having "log in" when there's no logged in user and "log out" when there's a logged in user present is good enough for now.

@bdougie
Copy link
Member

bdougie commented Jul 9, 2022

I comment on the wrong issues, but here is some context. #4 (comment)

We historically hide things that don't need to be in the header nav, i.e. "open an issue on github" link.

In the absence of a user profile, the dropdown should provide links specific to the user's experience.

  1. Logout is a minimum requirement
  2. I like having the report an issue link here.
  3. Perhaps we can link the changelog here too.

@pixelsbyeryc
Copy link
Contributor

We should use some of the code from: https://ariakit.org/examples/menu

It's already accessible and has the functionality we need.

@0-vortex
Copy link
Contributor

We should use some of the code from: https://ariakit.org/examples/menu

It's already accessible and has the functionality we need.

Think we are using https://www.radix-ui.com/docs/primitives/components/dropdown-menu in hot :D

Sorry for the late message had a severe injury 馃槄

@chadstewart
Copy link
Contributor Author

Think we are using https://www.radix-ui.com/docs/primitives/components/dropdown-menu in hot :D

Sorry for the late message had a severe injury sweat_smile

Yeah, we should probably use the component already in hot since we intend of building a design system across all the applications so we might as well borrow already built components from the other projects.

@pixelsbyeryc
Copy link
Contributor

That's perfect!

@pixelsbyeryc pixelsbyeryc removed the needs design Front-end tasks that are missing a design. Create a new issue for the design. label Jul 20, 2022
@github-actions
Copy link

馃帀 This issue has been resolved in version 1.0.0 馃帀

The release is available on GitHub release

Your semantic-release bot 馃摝馃殌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants