Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: pressing the remove filter icon button redirects to 404 #2423

Open
2 tasks done
adnanjpg opened this issue Jan 5, 2024 · 6 comments
Open
2 tasks done

Bug: pressing the remove filter icon button redirects to 404 #2423

adnanjpg opened this issue Jan 5, 2024 · 6 comments
Assignees
Labels
🐛 bug Something isn't working good first issue Good for newcomers
Milestone

Comments

@adnanjpg
Copy link

adnanjpg commented Jan 5, 2024

Describe the bug

Screen.Recording.2024-01-05.at.9.28.46.PM.mov

as seen in the video, clicking on the remove filter icon button will redirect to https://app.opensauced.pizza/hot/dashboard/undefined

Steps to reproduce

  1. go to https://hot.opensauced.pizza/
  2. type rust
  3. wait for the results, click on the first one to select it, then press Enter to navigate to it
  4. you will see that the dropdown on the left is empty (maybe that's why this is occuring)
  5. on the right, you will see Filter by: rust-lang/rust with a remove filter icon button
  6. click on the remove filter icon button, and it will redirect to https://app.opensauced.pizza/hot/dashboard/undefined

Browsers

Other (add additional context)

Additional context (Is this in dev or production?)

production, using the Arc browser (arc.net)

Code of Conduct

  • I agree to follow this project's Code of Conduct

Contributing Docs

  • I agree to follow this project's Contribution Docs
@adnanjpg adnanjpg added 🐛 bug Something isn't working 👀 needs triage labels Jan 5, 2024
Copy link

github-actions bot commented Jan 5, 2024

Thanks for the issue, our team will look into it as soon as possible! If you would like to work on this issue, please wait for us to decide if it's ready. The issue will be ready to work on once we remove the "needs triage" label.

To claim an issue that does not have the "needs triage" label, please leave a comment that says ".take". If you have any questions, please reach out to us on Discord or follow up on the issue itself.

For full info on how to contribute, please check out our contributors guide.

@jpmcb jpmcb added good first issue Good for newcomers and removed 👀 needs triage labels Jan 5, 2024
@jpmcb jpmcb added this to the Papercuts milestone Jan 5, 2024
@jpmcb
Copy link
Member

jpmcb commented Jan 5, 2024

This is more or less 2 fold:

  • The hot page shouldn't direct to hot/dashboard, it should direct to the topic like rust/dashboard (my guess is this is broken in the hot project since we haven't touched that much in a while
  • Removing the filter shouldn't lead to an undefined page, it should direct back to the {topic}/dashboard without the query params

@sourabpramanik
Copy link
Contributor

.take

@devharsh2k4
Copy link

Hey can i get assigned

@sourabpramanik
Copy link
Contributor

This issue doesn't exist anymore @devharsh2k4

@devharsh2k4
Copy link

ohh okk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants