feat: view on OpenSauced button #14

diivi · 2023-04-17T15:45:23Z

What type of PR is this? (check all applicable)

Description

Adds a View on OpenSauced button to GitHub profiles to get things started!

Related Tickets & Documents

#5

Mobile & Desktop Screenshots/Recordings

Added tests?

👍 yes
🙅 no, because they aren't needed
🙋 no, because I need help

Added to documentation?

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

diivi · 2023-04-17T15:46:08Z

I left the default CRXJs files in; we can remove them too.
@Anush008 @bdougie let me know what you think

src/components/ViewOnOpenSaucedButton/ViewOnOpenSaucedButton.css

0-vortex · 2023-04-17T15:56:48Z

some of the vite and npm based tooling can be copied over from the hot repo to enable auto release and deployments. let me know if you need help with setting that up 🍕

a litle bit of work is later needed in the workflows for chrome store releases to be part of github actions

src/components/ViewOnOpenSaucedButton/ViewOnOpenSaucedButton.ts

bdougie · 2023-04-17T16:26:06Z

some of the vite and npm based tooling can be copied over from the hot repo to enable auto release and deployments. let me know if you need help with setting that up 🍕

a litle bit of work is later needed in the workflows for chrome store releases to be part of github actions

That would be great. Looks like the publishing process to the chrome store is an uploaded zip folder.

0-vortex · 2023-04-17T16:45:28Z

some of the vite and npm based tooling can be copied over from the hot repo to enable auto release and deployments. let me know if you need help with setting that up 🍕
a litle bit of work is later needed in the workflows for chrome store releases to be part of github actions

That would be great. Looks like the publishing process to the chrome store is an uploaded zip folder.

Yes, that would be configured via https://crxjs.dev/vite-plugin/ and have to be added to our release tooling to extend the existing workflows

Anush008

LGTM.

bdougie

Going to merge so we can move forward with the other items. Keep in mind we want to get 2 approvals before "squashing" PRs.

doaortu

May I ask why tailwind normalizing classes are removed here @diivi ?

I want to use divide-y properties which uses border normalizing classes from tailwind, but the border is not showing because of this.

I just want to know why, and if that really justified, I can move on and find a workaround.

Thank you in advance

Anush008 · 2023-04-24T13:15:23Z

May I ask why tailwind normalizing classes are removed here @diivi ?

I want to use divide-y properties which uses border normalizing classes from tailwind, but the border is not showing because of this.

I just want to know why, and if that really justified, I can move on and find a workaround.

Thank you in advance

@diivi said the normalizing classes were conflicting with GitHub's styling. So he removed them to patch the issue.

doaortu · 2023-04-24T13:33:10Z

@diivi said the normalizing classes were conflicting with GitHub's styling. So he removed them to patch the issue.

Thank you for the quick response.
So that's why, ok then. I found the workaround just now. But writing tailwind without the normailizing classes felt really unintuitive. (for example: we need to explicitly use "border-solid" when we want to use border in our component, etc).
But I can live with that.

Thank you for the clarification

doaortu · 2023-04-24T13:43:46Z

I'd vote to keep the normalizing classes, because it's kind of confusing to use tailwind without that (most solutions online assumed we use tailwind with normalizing classes), especially for new contributors,
I have suggestion to solve that problem:
Option 1:

use Shadow Dom to isolate the styling in content scripts. hence we can keep using normalizing classes

Option 2:

use 2 different index.css files. one without the normalizing class, which is for content scripts, the other one with normalizing classes, we use this on the extension popup.

How's that sounds?

Note: I'm not to be obnoxious or anything, it's just my opinion to make it easier for anyone trying to contribute on this repository.

diivi · 2023-04-24T14:14:00Z

I'm fine with both options, feel free to create a PR for whichever one seems less complex to you!

Anush008 · 2023-04-24T14:17:16Z

@doaortu, you're free to make the changes. We'll talk about the changes and its implications in the PR discussion.

doaortu · 2023-04-24T14:47:57Z

Okay, I'll send the PR soon.

## 1.0.0 (2023-04-24) ### 📝 Documentation * README and LICENSE ([917f7b0](917f7b0)) * Updated the README.md ([open-sauced#15](https://github.com/diivi/browser-extensions/issues/15)) ([3e4dd69](3e4dd69)) ### 🍕 Features * extension window navigation ([open-sauced#21](https://github.com/diivi/browser-extensions/issues/21)) ([b5ae9a6](b5ae9a6)) * Invite to OpenSauced ([open-sauced#20](https://github.com/diivi/browser-extensions/issues/20)) ([0c8f222](0c8f222)) * updated the extension logo ([open-sauced#22](https://github.com/diivi/browser-extensions/issues/22)) ([d19034d](d19034d)) * view on OpenSauced button ([open-sauced#14](https://github.com/diivi/browser-extensions/issues/14)) ([a447551](a447551)) ### 🐛 Bug Fixes * make emails less creepy ([a08fa45](a08fa45)) * Wrapped the await call in an async() ([open-sauced#26](https://github.com/diivi/browser-extensions/issues/26)) ([357aab5](357aab5))

## 1.0.0 (2023-04-27) ### 📝 Documentation * README and LICENSE ([917f7b0](917f7b0)) * Updated the README.md ([open-sauced#15](https://github.com/diivi/browser-extensions/issues/15)) ([3e4dd69](3e4dd69)) ### 🍕 Features * extension window navigation ([open-sauced#21](https://github.com/diivi/browser-extensions/issues/21)) ([b5ae9a6](b5ae9a6)) * Invite to OpenSauced ([open-sauced#20](https://github.com/diivi/browser-extensions/issues/20)) ([0c8f222](0c8f222)) * updated the extension logo ([open-sauced#22](https://github.com/diivi/browser-extensions/issues/22)) ([d19034d](d19034d)) * view on OpenSauced button ([open-sauced#14](https://github.com/diivi/browser-extensions/issues/14)) ([a447551](a447551)) ### 🐛 Bug Fixes * make emails less creepy ([a08fa45](a08fa45)) * Wrapped the await call in an async() ([open-sauced#26](https://github.com/diivi/browser-extensions/issues/26)) ([357aab5](357aab5))

## 1.0.0-beta.1 (2023-04-27) ### 📝 Documentation * README and LICENSE ([917f7b0](917f7b0)) * Updated the README.md ([#15](#15)) ([3e4dd69](3e4dd69)) ### 🐛 Bug Fixes * rename the. extension ([294e499](294e499)) * Update URLs ([5828e20](5828e20)) * make emails less creepy ([a08fa45](a08fa45)) * re-enable tailwind base class on extension popup ([#31](#31)) ([c081217](c081217)) * Wrapped the await call in an async() ([#26](#26)) ([357aab5](357aab5)) ### 🍕 Features * add home page and profile page ([#36](#36)) ([8a43288](8a43288)) * Added a configuration file ([#32](#32)) ([ec6722c](ec6722c)) * Auto PAT authentication ([#29](#29)) ([f4f8cf6](f4f8cf6)) * extension window navigation ([#21](#21)) ([b5ae9a6](b5ae9a6)) * GitHub page update listener ([#37](#37)) ([06b070f](06b070f)) * Invite to OpenSauced ([#20](#20)) ([0c8f222](0c8f222)) * PAT authentication ([#27](#27)) ([e726a93](e726a93)) * updated the extension logo ([#22](#22)) ([d19034d](d19034d)) * view on OpenSauced button ([#14](#14)) ([a447551](a447551)) ### 🔁 Continuous Integration * automated github releases ([#39](#39)) ([735fa66](735fa66)), closes [#16](#16)

github-actions · 2023-04-27T15:53:33Z

🎉 This PR is included in version 1.0.0-beta.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

## 1.0.0 (2023-05-13) ### 📝 Documentation * README and LICENSE ([917f7b0](917f7b0)) * Updated the README.md ([#15](#15)) ([3e4dd69](3e4dd69)) ### 🔁 Continuous Integration * automated github releases ([#39](#39)) ([735fa66](735fa66)), closes [#16](#16) ### 🧑‍💻 Code Refactoring * improved-auth-strategy ([#56](#56)) ([d8b27c3](d8b27c3)) ### 🍕 Features * add home page and profile page ([#36](#36)) ([8a43288](8a43288)) * add to highlights button ([#64](#64)) ([e2120a1](e2120a1)) * Added a configuration file ([#32](#32)) ([ec6722c](ec6722c)) * Added light mode to GH profile buttons ([#40](#40)) ([a7ea43a](a7ea43a)) * Added linting to the project. ([#49](#49)) ([1f73007](1f73007)) * Auto PAT authentication ([#29](#29)) ([f4f8cf6](f4f8cf6)) * extension window navigation ([#21](#21)) ([b5ae9a6](b5ae9a6)) * GitHub page update listener ([#37](#37)) ([06b070f](06b070f)) * Invite to OpenSauced ([#20](#20)) ([0c8f222](0c8f222)) * PAT authentication ([#27](#27)) ([e726a93](e726a93)) * updated the extension logo ([#22](#22)) ([d19034d](d19034d)) * view on OpenSauced button ([#14](#14)) ([a447551](a447551)) * vote repos ([#70](#70)) ([ff2c8f4](ff2c8f4)) ### 🐛 Bug Fixes * rename the. extension ([294e499](294e499)) * Update URLs ([5828e20](5828e20)) * attach dist folder to release assets ([#47](#47)) ([4f50e72](4f50e72)) * circular-deps in vote buttons ([675496c](675496c)) * Duplicate buttons on GH profile page ([#48](#48)) ([9ee2dca](9ee2dca)) * incorrect request for voting ([#72](#72)) ([7a35014](7a35014)) * make emails less creepy ([a08fa45](a08fa45)) * re-enable tailwind base class on extension popup ([#31](#31)) ([c081217](c081217)) * remove activeTab manifest.json ([#50](#50)) ([dd71480](dd71480)) * render emojis in user bio ([#68](#68)) ([d0158a5](d0158a5)) * set-output deprecation warning ([#51](#51)) ([486f84b](486f84b)) * unrecognized-manifest-key ([#55](#55)) ([d622500](d622500)) * Wrapped the await call in an async() ([#26](#26)) ([357aab5](357aab5))

github-actions · 2023-05-13T13:17:38Z

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

## 1.0.0-beta.1 (2023-04-27) ### 📝 Documentation * README and LICENSE ([917f7b0](open-sauced/ai@917f7b0)) * Updated the README.md ([#15](open-sauced/ai#15)) ([3e4dd69](open-sauced/ai@3e4dd69)) ### 🐛 Bug Fixes * rename the. extension ([294e499](open-sauced/ai@294e499)) * Update URLs ([5828e20](open-sauced/ai@5828e20)) * make emails less creepy ([a08fa45](open-sauced/ai@a08fa45)) * re-enable tailwind base class on extension popup ([#31](open-sauced/ai#31)) ([c081217](open-sauced/ai@c081217)) * Wrapped the await call in an async() ([#26](open-sauced/ai#26)) ([357aab5](open-sauced/ai@357aab5)) ### 🍕 Features * add home page and profile page ([#36](open-sauced/ai#36)) ([8a43288](open-sauced/ai@8a43288)) * Added a configuration file ([#32](open-sauced/ai#32)) ([ec6722c](open-sauced/ai@ec6722c)) * Auto PAT authentication ([#29](open-sauced/ai#29)) ([f4f8cf6](open-sauced/ai@f4f8cf6)) * extension window navigation ([#21](open-sauced/ai#21)) ([b5ae9a6](open-sauced/ai@b5ae9a6)) * GitHub page update listener ([#37](open-sauced/ai#37)) ([06b070f](open-sauced/ai@06b070f)) * Invite to OpenSauced ([#20](open-sauced/ai#20)) ([0c8f222](open-sauced/ai@0c8f222)) * PAT authentication ([#27](open-sauced/ai#27)) ([e726a93](open-sauced/ai@e726a93)) * updated the extension logo ([#22](open-sauced/ai#22)) ([d19034d](open-sauced/ai@d19034d)) * view on OpenSauced button ([#14](open-sauced/ai#14)) ([a447551](open-sauced/ai@a447551)) ### 🔁 Continuous Integration * automated github releases ([#39](open-sauced/ai#39)) ([735fa66](open-sauced/ai@735fa66)), closes [#16](open-sauced/ai#16)

## 1.0.0 (2023-05-13) ### 📝 Documentation * README and LICENSE ([917f7b0](open-sauced/ai@917f7b0)) * Updated the README.md ([#15](open-sauced/ai#15)) ([3e4dd69](open-sauced/ai@3e4dd69)) ### 🔁 Continuous Integration * automated github releases ([#39](open-sauced/ai#39)) ([735fa66](open-sauced/ai@735fa66)), closes [#16](open-sauced/ai#16) ### 🧑‍💻 Code Refactoring * improved-auth-strategy ([#56](open-sauced/ai#56)) ([d8b27c3](open-sauced/ai@d8b27c3)) ### 🍕 Features * add home page and profile page ([#36](open-sauced/ai#36)) ([8a43288](open-sauced/ai@8a43288)) * add to highlights button ([#64](open-sauced/ai#64)) ([e2120a1](open-sauced/ai@e2120a1)) * Added a configuration file ([#32](open-sauced/ai#32)) ([ec6722c](open-sauced/ai@ec6722c)) * Added light mode to GH profile buttons ([#40](open-sauced/ai#40)) ([a7ea43a](open-sauced/ai@a7ea43a)) * Added linting to the project. ([#49](open-sauced/ai#49)) ([1f73007](open-sauced/ai@1f73007)) * Auto PAT authentication ([#29](open-sauced/ai#29)) ([f4f8cf6](open-sauced/ai@f4f8cf6)) * extension window navigation ([#21](open-sauced/ai#21)) ([b5ae9a6](open-sauced/ai@b5ae9a6)) * GitHub page update listener ([#37](open-sauced/ai#37)) ([06b070f](open-sauced/ai@06b070f)) * Invite to OpenSauced ([#20](open-sauced/ai#20)) ([0c8f222](open-sauced/ai@0c8f222)) * PAT authentication ([#27](open-sauced/ai#27)) ([e726a93](open-sauced/ai@e726a93)) * updated the extension logo ([#22](open-sauced/ai#22)) ([d19034d](open-sauced/ai@d19034d)) * view on OpenSauced button ([#14](open-sauced/ai#14)) ([a447551](open-sauced/ai@a447551)) * vote repos ([#70](open-sauced/ai#70)) ([ff2c8f4](open-sauced/ai@ff2c8f4)) ### 🐛 Bug Fixes * rename the. extension ([294e499](open-sauced/ai@294e499)) * Update URLs ([5828e20](open-sauced/ai@5828e20)) * attach dist folder to release assets ([#47](open-sauced/ai#47)) ([4f50e72](open-sauced/ai@4f50e72)) * circular-deps in vote buttons ([675496c](open-sauced/ai@675496c)) * Duplicate buttons on GH profile page ([#48](open-sauced/ai#48)) ([9ee2dca](open-sauced/ai@9ee2dca)) * incorrect request for voting ([#72](open-sauced/ai#72)) ([7a35014](open-sauced/ai@7a35014)) * make emails less creepy ([a08fa45](open-sauced/ai@a08fa45)) * re-enable tailwind base class on extension popup ([#31](open-sauced/ai#31)) ([c081217](open-sauced/ai@c081217)) * remove activeTab manifest.json ([#50](open-sauced/ai#50)) ([dd71480](open-sauced/ai@dd71480)) * render emojis in user bio ([#68](open-sauced/ai#68)) ([d0158a5](open-sauced/ai@d0158a5)) * set-output deprecation warning ([#51](open-sauced/ai#51)) ([486f84b](open-sauced/ai@486f84b)) * unrecognized-manifest-key ([#55](open-sauced/ai#55)) ([d622500](open-sauced/ai@d622500)) * Wrapped the await call in an async() ([#26](open-sauced/ai#26)) ([357aab5](open-sauced/ai@357aab5))

feat: view on OpenSauced button

a4676e9

diivi requested review from bdougie and Anush008 April 17, 2023 15:46

bdougie reviewed Apr 17, 2023

View reviewed changes

src/components/ViewOnOpenSaucedButton/ViewOnOpenSaucedButton.css Outdated Show resolved Hide resolved

Anush008 marked this pull request as ready for review April 17, 2023 16:12

Anush008 requested changes Apr 17, 2023

View reviewed changes

src/components/ViewOnOpenSaucedButton/ViewOnOpenSaucedButton.ts Outdated Show resolved Hide resolved

Anush008 marked this pull request as draft April 17, 2023 16:16

diivi added 4 commits April 17, 2023 22:22

add tailwindcss

bf2c038

remove tailwind normalising classes

48d3e6a

remove yarn and run shrinkwrap

3ed76e7

separate content-scripts and components

9bde294

Anush008 approved these changes Apr 17, 2023

View reviewed changes

Anush008 marked this pull request as ready for review April 17, 2023 18:42

bdougie approved these changes Apr 17, 2023

View reviewed changes

bdougie merged commit a447551 into main Apr 17, 2023

diivi deleted the feat/view-on-opensauced-button branch April 17, 2023 20:23

diivi linked an issue Apr 18, 2023 that may be closed by this pull request

Initial extension with "View on OpenSauced" button. #5

Closed

Anush008 mentioned this pull request Apr 21, 2023

fix: Wrapped the await call in an async() #26

Merged

19 tasks

doaortu reviewed Apr 24, 2023

View reviewed changes

doaortu mentioned this pull request Apr 24, 2023

fix: re-enable tailwind base class on extension popup #31

Merged

19 tasks

github-actions bot added the released on @beta label Apr 27, 2023

github-actions bot added the released label May 13, 2023

diivi mentioned this pull request Jul 17, 2023

feat: view repos on opensauced #218

Merged

19 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: view on OpenSauced button #14

feat: view on OpenSauced button #14

diivi commented Apr 17, 2023

diivi commented Apr 17, 2023

0-vortex commented Apr 17, 2023

bdougie commented Apr 17, 2023

0-vortex commented Apr 17, 2023

Anush008 left a comment

bdougie left a comment

doaortu left a comment •

edited

Anush008 commented Apr 24, 2023 •

edited

doaortu commented Apr 24, 2023 •

edited

doaortu commented Apr 24, 2023 •

edited

diivi commented Apr 24, 2023 •

edited

Anush008 commented Apr 24, 2023

doaortu commented Apr 24, 2023

github-actions bot commented Apr 27, 2023

github-actions bot commented May 13, 2023

feat: view on OpenSauced button #14

feat: view on OpenSauced button #14

Conversation

diivi commented Apr 17, 2023

What type of PR is this? (check all applicable)

Description

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings

Added tests?

Added to documentation?

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

diivi commented Apr 17, 2023

0-vortex commented Apr 17, 2023

bdougie commented Apr 17, 2023

0-vortex commented Apr 17, 2023

Anush008 left a comment

Choose a reason for hiding this comment

bdougie left a comment

Choose a reason for hiding this comment

doaortu left a comment • edited

Choose a reason for hiding this comment

Anush008 commented Apr 24, 2023 • edited

doaortu commented Apr 24, 2023 • edited

doaortu commented Apr 24, 2023 • edited

diivi commented Apr 24, 2023 • edited

Anush008 commented Apr 24, 2023

doaortu commented Apr 24, 2023

github-actions bot commented Apr 27, 2023

github-actions bot commented May 13, 2023

doaortu left a comment •

edited

Anush008 commented Apr 24, 2023 •

edited

doaortu commented Apr 24, 2023 •

edited

doaortu commented Apr 24, 2023 •

edited

diivi commented Apr 24, 2023 •

edited