Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add/remove repos to/from insights. #77

Merged
merged 4 commits into from
May 16, 2023
Merged

Conversation

diivi
Copy link
Collaborator

@diivi diivi commented May 15, 2023

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation Update
  • 🎨 Style
  • πŸ§‘β€πŸ’» Code Refactor
  • πŸ”₯ Performance Improvements
  • βœ… Test
  • πŸ€– Build
  • πŸ” CI
  • πŸ“¦ Chore (Release)
  • ⏩ Revert

Description

This PR will allow users to add or remove repos on GitHub to/from insights on OpenSauced.
It adds a dropdown select menu similar to GitHub's list menu without sacrificing our look and feel.

Related Tickets & Documents

#13

Mobile & Desktop Screenshots/Recordings

image

Added tests?

  • πŸ‘ yes
  • πŸ™… no, because they aren't needed
  • πŸ™‹ no, because I need help

Added to documentation?

  • πŸ“œ README.md
  • πŸ““ docs.opensauced.pizza
  • πŸ• dev.to/opensauced
  • πŸ“• storybook
  • πŸ™… no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

@diivi diivi marked this pull request as ready for review May 15, 2023 14:38
@diivi diivi requested a review from Anush008 May 15, 2023 14:39
@Anush008
Copy link
Member

Anush008 commented May 15, 2023

@diivi, this looks great!! Can the dropdown arrow be a little bigger? It's a little hard to click.
Or maybe have the entire far right section of the vote button trigger the dropdown and not just the arrow.
Untitled

@bdougie
Copy link
Member

bdougie commented May 15, 2023

I was able to get the two buttons to show by click on the other dropdowns for "watching" and "forks"

Screen Shot 2023-05-15 at 8 48 31 AM

Can we move the title to align left like the other dropdowns as well as add an X to close the dropdown.

Screen Shot 2023-05-15 at 8 49 42 AM Screen Shot 2023-05-15 at 8 47 53 AM

Also please try to match the fonts and font colors.

Copy link
Member

@bdougie bdougie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to match GitHub Dropdown a bit more. Functionality works.

@diivi
Copy link
Collaborator Author

diivi commented May 16, 2023

I copied GitHub's classes, @bdougie can you check now?

image
image

I could not reproduce your issue with the duplicate buttons though, can you tell me the steps you took to get that?

Copy link
Member

@bdougie bdougie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could not reproduce the error I found.

@bdougie
Copy link
Member

bdougie commented May 16, 2023

@diivi I think this feature needs some documentation. We are starting to add features that need some explanation.

open-sauced/docs#85

@bdougie bdougie merged commit 8e4a6ed into beta May 16, 2023
3 checks passed
github-actions bot pushed a commit that referenced this pull request May 16, 2023
## [1.1.0-beta.2](v1.1.0-beta.1...v1.1.0-beta.2) (2023-05-16)

### πŸ• Features

* add/remove repos to/from insights. ([#77](#77)) ([8e4a6ed](8e4a6ed))
@github-actions
Copy link

πŸŽ‰ This PR is included in version 1.1.0-beta.2 πŸŽ‰

The release is available on GitHub release

Your semantic-release bot πŸ“¦πŸš€

github-actions bot pushed a commit that referenced this pull request May 20, 2023
## [1.1.0](v1.0.0...v1.1.0) (2023-05-20)

### πŸ“ Documentation

* how we create extension releases ([#81](#81)) ([10b1c48](10b1c48))

### πŸ› Bug Fixes

* add extra line and italics ([#93](#93)) ([2cbd790](2cbd790))
* update name in README ([dba4734](dba4734))

### πŸ• Features

* add/remove repos to/from insights. ([#77](#77)) ([8e4a6ed](8e4a6ed))
* OpenSauced AI PR description  ([#79](#79)) ([0e38777](0e38777))
* replace open issues count with highlights count ([#76](#76)) ([0fb8149](0fb8149))
* Updated to the new AI PR description endpoint ([#94](#94)) ([cf8f64c](cf8f64c))
@github-actions
Copy link

πŸŽ‰ This PR is included in version 1.1.0 πŸŽ‰

The release is available on GitHub release

Your semantic-release bot πŸ“¦πŸš€

@Anush008 Anush008 deleted the feat/add-repo-to-insights branch June 11, 2023 10:53
zer0and1 pushed a commit to zer0and1/open-sauced.ai that referenced this pull request Jul 26, 2023
## [1.1.0-beta.2](open-sauced/ai@v1.1.0-beta.1...v1.1.0-beta.2) (2023-05-16)

### πŸ• Features

* add/remove repos to/from insights. ([#77](open-sauced/ai#77)) ([8e4a6ed](open-sauced/ai@8e4a6ed))
zer0and1 pushed a commit to zer0and1/open-sauced.ai that referenced this pull request Jul 26, 2023
## [1.1.0](open-sauced/ai@v1.0.0...v1.1.0) (2023-05-20)

### πŸ“ Documentation

* how we create extension releases ([#81](open-sauced/ai#81)) ([10b1c48](open-sauced/ai@10b1c48))

### πŸ› Bug Fixes

* add extra line and italics ([#93](open-sauced/ai#93)) ([2cbd790](open-sauced/ai@2cbd790))
* update name in README ([dba4734](open-sauced/ai@dba4734))

### πŸ• Features

* add/remove repos to/from insights. ([#77](open-sauced/ai#77)) ([8e4a6ed](open-sauced/ai@8e4a6ed))
* OpenSauced AI PR description  ([#79](open-sauced/ai#79)) ([0e38777](open-sauced/ai@0e38777))
* replace open issues count with highlights count ([#76](open-sauced/ai#76)) ([0fb8149](open-sauced/ai@0fb8149))
* Updated to the new AI PR description endpoint ([#94](open-sauced/ai#94)) ([cf8f64c](open-sauced/ai@cf8f64c))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants