Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: convert to cloudflare workers template #2

Merged
merged 6 commits into from Mar 1, 2022

Conversation

0-vortex
Copy link
Contributor

@0-vortex 0-vortex commented Feb 16, 2022

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation Update
  • 🎨 Style
  • πŸ§‘β€πŸ’» Code Refactor
  • πŸ”₯ Performance Improvements
  • βœ… Test
  • πŸ€– Build
  • πŸ” CI
  • πŸ“¦ Chore (Release)
  • ⏩ Revert

Description

This PR converts the robot app to a workers compatible template and adds some basic tooling.

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings

Added tests?

  • πŸ‘ yes
  • πŸ™… no, because they aren't needed
  • πŸ™‹ no, because I need help

Added to documentation?

  • πŸ“œ README.md
  • πŸ““ docs.opensauced.pizza
  • πŸ• dev.to/opensauced
  • πŸ“• storybook
  • πŸ™… no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

  • disable the dashboard page (not needed anymore)
  • disable the deployment flow (can leak the webhook URL)
  • verify github signature
  • convert miniflare build to vite
  • add docker workflow
  • implement miniflare

[optional] What gif best describes this PR or how it makes you feel?

@0-vortex 0-vortex marked this pull request as ready for review February 19, 2022 17:46
branches:
- main
- alpha
- beta
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make sense to npx wrangler after a successful release?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried that in 5f3b486 but it leaks deployment URL :/ can put it back and test it out for a while

Copy link
Member

@bdougie bdougie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks good to me. Only left a comment about leveraging wrangler for continuous deploymeny.

@bdougie bdougie merged commit 07af51b into open-sauced:main Mar 1, 2022
@github-actions
Copy link

πŸŽ‰ This PR is included in version 1.0.0 πŸŽ‰

The release is available on GitHub release

Your semantic-release bot πŸ“¦πŸš€

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants