Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Connect stars to API star service in the API #355

Closed
Tracked by #351
bdougie opened this issue Oct 4, 2022 · 4 comments
Closed
Tracked by #351

Connect stars to API star service in the API #355

bdougie opened this issue Oct 4, 2022 · 4 comments
Assignees
@takanome-dev
Milestone
Working Submissio...

Comments

@bdougie
Copy link
Member

bdougie commented Oct 4, 2022 •
edited

What is this?

Multiple places display stars. I am looking to empower users to stars repos from the hot UI.

Screen Shot 2022-10-03 at 11 08 27 PM

Screen Shot 2022-10-03 at 11 11 36 PM

how to implement

Screen Shot 2022-10-03 at 11 08 53 PM

Use the API to create a useStarRepos similar to useVotedRepos
@bdougie bdougie mentioned this issue Oct 4, 2022
Closed
7 tasks
@bdougie bdougie added this to the Working Submissions and WAU milestone Oct 4, 2022
@takanome-dev
Copy link
Contributor

I will .take this one and if I implement the useStarRepos hook, it will be easier, I think, to make #358 work ✌️

@github-actions
Copy link

Thanks for taking this on! If you have not already, join the conversation in our Discord

@takanome-dev
Copy link
Contributor

@0-vortex we don't have the loading skeleton #374 because of the latest changes made, I would like to suggest passing down isLoading to ListRepositories.tsx instead of not rendering it until isLoading is false (footer still shows up)

Want to hear your thoughts on that 🙌

@takanome-dev takanome-dev mentioned this issue Oct 25, 2022
Closed
19 tasks
@takanome-dev
Copy link
Contributor

takanome-dev commented Dec 2, 2022 •
edited

This issue needs to be closed as well since #387 is not needed 🚫

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@takanome-dev takanome-dev

Labels
None yet
Projects
hot.opensauced.pizza
Status: Done
Milestone
Working Submissions and WAU
Development

Successfully merging a pull request may close this issue.

feat: connect stars to api service takanome-dev/hot.opensauced.pizza
2 participants
@bdougie @takanome-dev