Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Search pop-up don't close If I shot Escape #418

Closed
2 tasks done
NsdHSO opened this issue Nov 30, 2022 · 4 comments 路 Fixed by #445
Closed
2 tasks done

Feature: Search pop-up don't close If I shot Escape #418

NsdHSO opened this issue Nov 30, 2022 · 4 comments 路 Fixed by #445
Assignees
@RozzaysRed
Labels
馃挕 feature released on @beta released

Comments

@NsdHSO
Copy link
Contributor

NsdHSO commented Nov 30, 2022

Type of feature

馃崟 Feature

Current behavior

image

Suggested solution

I was expecting the pop-up to close when I pressed escape

#415

Additional context

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct

Contributing Docs

  • I agree to follow this project's Contribution Docs
@takanome-dev
Copy link
Contributor

takanome-dev commented Nov 30, 2022 •
edited

As commented on #415 (comment) using headlessui combobox will fix that

update: we can leverage radix components as @0-vortex suggested #415 (comment)

@NsdHSO NsdHSO mentioned this issue Dec 8, 2022
Open
6 tasks
@RozzaysRed
Copy link
Contributor

.take

@RozzaysRed RozzaysRed mentioned this issue Feb 2, 2023
Merged
19 tasks
@github-actions
Copy link

馃帀 This issue has been resolved in version 2.31.0-beta.12 馃帀

The release is available on:

Your semantic-release bot 馃摝馃殌

@github-actions
Copy link

馃帀 This issue has been resolved in version 2.31.0 馃帀

The release is available on:

Your semantic-release bot 馃摝馃殌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RozzaysRed RozzaysRed

Labels
馃挕 feature released on @beta released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Close search pop-up when escape is pressed RozzaysRed/hot
3 participants
@RozzaysRed @NsdHSO @takanome-dev