Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: active link indicator doesn't work on feature (home) page #149

Closed
2 tasks done
wasimapinjari opened this issue Jul 30, 2023 · 6 comments
Closed
2 tasks done
Labels
🐛 bug Something isn't working

Comments

@wasimapinjari
Copy link
Contributor

Describe the bug

This may be an intentional design choice.

But clicking on the "Features" link doesn't show the orange border bottom indicating to the user that they are currently viewing the "Features" page.

Sequence.01_1.mp4

Steps to reproduce

  1. Click on the "Features" link

Browsers

Chrome

Additional context (Is this in dev or production?)

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct

Contributing Docs

  • I agree to follow this project's Contribution Docs
@wasimapinjari wasimapinjari added 🐛 bug Something isn't working 👀 needs triage labels Jul 30, 2023
@bdougie
Copy link
Member

bdougie commented Aug 2, 2023

We do not need the features underlined when the page is visited without the routes. If it is possible only to add the underline when the URL includes the features route, I would say let's do it.

This is not a high priority fix

@dev-phantom
Copy link
Contributor

We do not need the features underlined when the page is visited without the routes. If it is possible only to add the underline when the URL includes the features route, I would say let's do it.

This is not a high priority fix

i guess adding an activeClass to the tab that is currently active should fix this

@dev-phantom
Copy link
Contributor

We do not need the features underlined when the page is visited without the routes. If it is possible only to add the underline when the URL includes the features route, I would say let's do it.
This is not a high priority fix

i guess adding an activeClass to the tab that is currently active should fix this

@bdougie what is your take on this?

@bdougie
Copy link
Member

bdougie commented Aug 7, 2023

I don't have a take

@wasimapinjari
Copy link
Contributor Author

Fun hover effect 😃

Sequence.01_1.mp4

@dev-phantom
Copy link
Contributor

I don't think there a need for this issue
can you kindly close this

@wasimapinjari wasimapinjari closed this as not planned Won't fix, can't repro, duplicate, stale Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants