fix(actions): removed failing production cache and updated npm

[0-vortex]

What type of PR is this? (check all applicable)

• ♻️ Refactor
• ✨ Feature
• 🐛 Bug Fix
• 👷 Optimization
• 📝 Documentation Update
• 🔖 Release
• 🚩 Other

Description

Cache doesn't work with npm ci and is bad pratice on production builds. Not sure we would have much benefit from it outside of pull requests.

Updated to npm@7 to make everything forward compatible.

Related Tickets & Documents

Should magically unblock #1011

Does testing this on my fork work if I just enable actions to build from settings ?

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

Added tests?

• 👍 yes
• 🙅 no, because they aren't needed
• 🙋 no, because I need help

Added to documentation?

• 📜 readme
• 📜 contributing.md
• 📓 docs
• 🙅 no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

[bdougie]

Cache doesn't work with npm ci and is bad pratice on production builds. Not sure we would have much benefit from it outside of pull requests.

@0-vortex do you have more context on this?

[bdougie]

Actually, I found this article. voorhoede.nl/en/blog/super-fast-npm-install-on-github-actions/

Because npm ci removes the node_modules, leveraging the actions/cache is redundant. We can go with this PR so we can move forward on the Quality of life PR.

[0-vortex]

Actually, I found this article. voorhoede.nl/en/blog/super-fast-npm-install-on-github-actions/

Because npm ci removes the node_modules, leveraging the actions/cache is redundant. We can go with this PR so we can move forward on the Quality of life PR.

interesting read, I got my logic from the docs actually: https://github.com/actions/cache/blob/main/examples.md#node---npm