This repository has been archived by the owner on May 25, 2023. It is now read-only.
feat: Add link to user's open-sauced goals #1016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filiptronicek
suggested changes
May 25, 2021
filiptronicek
approved these changes
May 25, 2021
bdougie
suggested changes
May 25, 2021
| <small> | ||
| <em>You own all your data saved while saucin.</em> | ||
| </small> | ||
| </React.Fragment> | ||
| ); | ||
| } | ||
|
|
||
| function InstallApp() { | ||
| function InstallApp({user}) { | ||
| const repoUrl = `https://github.com/${user.login}/open-sauced-goals`; |
There was a problem hiding this comment.
This should link to open-sauced/goals-template instead
There was a problem hiding this comment.
So we don't need the user context then?
There was a problem hiding this comment.
Wow, reviewing this on stream had me miss-read this. I event tested it wrong. This is good to go as is. The context of the user is needed.
bdougie
approved these changes
May 25, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
#948 by adding a link to user's newly created open-sauced-goals repo. As mentioned in issue commentary, redirect to this repo after installation steps may require passing state to app's OAuth flow along with configuration changes to the open-sauced GitHub app itself.
Related Tickets & Documents
Mobile & Desktop Screenshots/Recordings (if there are UI changes)
Added tests?
Added to documentation?
[optional] Are there any post-deployment tasks we need to perform?
[optional] What gif best describes this PR or how it makes you feel?