feat: Updating storybook #1037
feat: Updating storybook #1037
Conversation
…torybook. Need to look into RecommendedRepoListCard, Getting Started and Onboarding Card.
…epo List. Need to add Contributors to Storybook but not sure where and need to look out for components not used.
…eous. Need to get other project contributors to review work.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Congrats on making your first Pull Request and thanks for taking the time to improve Open Sauced! ❤️! 🎉🍕
Say hello by joining the conversation in our Discord
|
@chadstewart thanks for the PR. Can you include a few more things in this PR?
|
stories/3-Primitives.stories.js
Outdated
| </Gradient> | ||
| </React.Fragment> | ||
| ); | ||
|
|
||
| export const ProfileAvatar = () => ( | ||
| <Background style={{height: 1024, padding: "10px"}}> | ||
| <Avatar src={face} alt="profile pic" /> |
There was a problem hiding this comment.
See this as a rectangle rather than a square. Are you seeing this?
There was a problem hiding this comment.
Updated this so it is a square instead of a rectangle and will be added upon completion of all the other suggestions.
| @@ -13,6 +18,9 @@ export const HomePage = () => ( | |||
| <Fragment> | |||
There was a problem hiding this comment.
I am seeing the Hero there twice.
There was a problem hiding this comment.
Removed the extra category for Hero and moved that into Homepage category and will be added upon completion of all the other suggestions.
Okay, no problem. I actually have a question on this. So all the other categories are pretty self-explanatory to me but I just realized as I was planning out the doc file, I honestly don't know what Primitives are. While I was working, I put the theme mode buttons there just because it seemed appropriate but now I'm wondering if they belong there or if they should be put in Miscellaneous or buttons instead. I'm also wondering if profile picture should be moved as well. Let me know whenever you are able and thank you! |
Correct me if I'm wrong, not sure if this changed in popular opinion but primitives in this context are react-native elements, unstyled cross-platform aware default components like Text. The concept has been integrated to React, leading to primitive interfaces for the web, some examples I am familiar with: TL;DR: what a primitive should be, similar to JS primitives is an immutable component(interface) used as a baseline for other components (Text, Paragraph, etc) |
It really sounds like I should take out what it in Primitives currently and put them in buttons and Miscellaneous. I don't think we have any stories that is showcasing just primitives. Do we need stories that showcase those? |
|
@chadstewart I think you can add everything in the https://github.com/open-sauced/open-sauced/tree/main/src/styles/Typography folder and remove everything else. |
…styles from Typography to Primitives category
|
Added the Typography to the Primitives category. Quick note though. I noticed that Microfont and Tinyfont have the same size of font.default. Not sure if it's meant to be that way but it was just something I noticed. |
|
…uttonsin Miscellaneous.
|
Trying to update my pull request description but for some reason it won't let me update the comment. The button isn't highlighted. Do I have to just write a new comment? |
|
Are you are saying this dropdown is not showing?
|
It was more the green Update Comment was greyed out.
I reloaded the page and I was able to update the comment. I think the issue was that I was trying to update the page while your checks was running. Sorry about the trouble, I'm a little new to all of this honestly. |
|
Upon further review, you need org access to edit the OP. You should have gotten an invite to join. |
| <li><b>Miscellaneous:</b> These are components that currently don't fit neatly into the above categories.</li> | ||
| </ul> | ||
|
|
||
| ## Making changes to Storybook |
There was a problem hiding this comment.
Are you still working on this? I think this is close to good, just saw this section was empty.
There was a problem hiding this comment.
Oh sorry. It was meant to be a header for the section. I made some changes to the docs to make it a bit more clear and made the necessary formatting changes to the other headings under it.
…section was a bit unclear because of formatting and lack of context to explain what the section was for.
What type of PR is this? (check all applicable)
Description
Updated Storybook to with current UI elements in project including adding buttons, cards and other UI elements previously not in Storybook, updating existing elements in Storybook to their current iterations and deleting UI elements that no longer appeared in the project. Looking to ensure that I've covered every UI element in the project as I went through added and updated the ones I visually saw on the project. I am still unfamiliar with the project so I might have missed a few. I don't think there was any gotchas that I came across honestly but whatever issue I was having an issue with I tried to represent in the Storybook doc in this pull request.
Related Tickets & Documents
Feature #952
Mobile & Desktop Screenshots/Recordings (if there are UI changes)
Added tests?
Added to documentation?
[optional] Are there any post-deployment tasks we need to perform?
[optional] What gif best describes this PR or how it makes you feel?