Skip to content
This repository has been archived by the owner on May 25, 2023. It is now read-only.

feat: Change use-shopping-cart logo #1098

Merged
merged 5 commits into from
Jul 17, 2021

Conversation

daptheHuman
Copy link
Contributor

What type of PR is this? (check all applicable)

  • ♻️ Refactor
  • ✨ Feature
  • 🐛 Bug Fix
  • 👷 Optimization
  • 📝 Documentation Update
  • 🔖 Release
  • 🚩 Other

Description

This PR replaces the old "use-shopping-cart" logo into the new one, that the https://useshoppingcart.com uses

Related Tickets & Documents

Fixes #1084

Mobile & Desktop Screenshots/Recordings

image

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help

Added to documentation?

  • 📜 readme
  • 📜 contributing.md
  • 📓 docs
  • 📕 storybook
  • 🙅 no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

N/A

[optional] What gif best describes this PR or how it makes you feel?

smiley

@0-vortex
Copy link
Contributor

LGTM!

Screenshot 2021-07-17 at 07 53 16

@0-vortex 0-vortex merged commit a8555ed into open-sauced:main Jul 17, 2021
@filiptronicek
Copy link
Sponsor Contributor

LGTM!

Screenshot 2021-07-17 at 07 53 16

@0-vortex as a follow up, it seems that the contrast on the logos is pretty low, maybe we could make an issue about that?

@0-vortex
Copy link
Contributor

LGTM!
Screenshot 2021-07-17 at 07 53 16

@0-vortex as a follow-up, it seems that the contrast on the logos is pretty low, maybe we could make an issue about that?

Oh snap I didn't even see there was a cart there :D
A bit conflicted about what a good solution for that would be - looking at the logo a yellow outline could fix or ruin it, but should totally open up an issue about that!

@filiptronicek
Copy link
Sponsor Contributor

@0-vortex what about we make every logo card? A box with its own contrasting background?

@daptheHuman
Copy link
Contributor Author

@0-vortex @filiptronicek i dont even notice on dark mode😂 i went to the light mode that time

@0-vortex
Copy link
Contributor

@0-vortex what about we make every logo card? A box with its own contrasting background?

Yeah that's what I was thinking, it's either beautiful or bust :D

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Update logo for use-shopping-cart
3 participants