feat: additional pr compliance checks #1178
Conversation
.github/workflows/compliance.yml
Outdated
| @@ -15,6 +16,16 @@ jobs: | |||
| env: | |||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | |||
|
|
|||
| compliance-checks: | |||
There was a problem hiding this comment.
would replace this with semantics or just prefix it with pr/pull request
There was a problem hiding this comment.
changed wording. would we still want the semantics action?
|
closing the pull request is an anti-pattern with the squash feature as it doesn't really affect the main branch history or parallel pull requests, any way to disable/switch that to a comment? |
|
Thought I overheard bdougie say the auto close was desired behavior. We can set these inputs: body-auto-close: false I did manage to get the README updated for inputs and such, and I updated the regex for the other verbs like fix and close. |
Awesome, it has my vote! |
## [0.32.0](v0.31.0...v0.32.0) (2021-10-08) ### Features * additional pr compliance checks ([#1178](#1178)) ([c8a2a39](c8a2a39))
|
🎉 This PR is included in version 0.32.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
What type of PR is this? (check all applicable)
Description
I've been working on an action lately that we might be able to implement here in early October.
Among other checks, this looks for PRs not being linked to an issue, not being from the right branch, having incorrect title, and/or modifying key files.
https://github.com/mtfoley/pr-compliance-action
I don't know the right way though to have this interact with the "welcome action". The semantic release action fails a check, but it's only looking at the issue. This new one will close the PR on a missing issue reference or having the wrong head branch, and that could be kind of a mixed signal with the welcome for first time contributors.
Related Tickets & Documents
This PR closes #745.
Mobile & Desktop Screenshots/Recordings
Added tests?
Added to documentation?
[optional] Are there any post-deployment tasks we need to perform?
psssh probably
[optional] What gif best describes this PR or how it makes you feel?