Skip to content
This repository has been archived by the owner on May 25, 2023. It is now read-only.

fix: no add response #1220

Merged
merged 1 commit into from
Oct 12, 2021
Merged

fix: no add response #1220

merged 1 commit into from
Oct 12, 2021

Conversation

mtfoley
Copy link
Contributor

@mtfoley mtfoley commented Oct 12, 2021

What type of PR is this? (check all applicable)

  • ♻️ Refactor
  • ✨ Feature
  • 🐛 Bug Fix
  • 👷 Optimization
  • 📝 Documentation Update
  • 🔖 Release
  • 🚩 Other

Description

This PR fixes the issue of ListGoals component not updating when adding/removing a goal. May also help with Stars Syncing.

I could tell that the useSWR was doing it's thing for updating goals data, but it looks like we needed a useEffect to move the listGoals state value forward with changes.

Related Tickets & Documents

Fixes #832
Fixes #986

Possibly related to #1219

Mobile & Desktop Screenshots/Recordings

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help

Added to documentation?

  • 📜 readme
  • 📜 contributing.md
  • 📓 docs
  • 📕 storybook
  • 🙅 no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

Not a GIF, but um...
eureka

@0-vortex
Copy link
Contributor

totally fast-forwarding this! 🚀

@0-vortex 0-vortex merged commit 102cae9 into open-sauced:main Oct 12, 2021
github-actions bot pushed a commit that referenced this pull request Oct 12, 2021
@mtfoley @open-sauced
chore(release): 0.34.1
3c8d85f 
### [0.34.1](v0.34.0...v0.34.1) (2021-10-12)

### Bug Fixes

* no add response ([#1220](#1220)) ([102cae9](102cae9)), closes [#832](#832) [#986](#986)
@github-actions
Copy link
Contributor

🎉 This PR is included in version 0.34.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@mtfoley mtfoley mentioned this pull request Oct 13, 2021
Closed
1 task
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Remove From Dashboard button doesn’t work Bug: Adding a repo presents no response
2 participants
@mtfoley @0-vortex