-
-
Notifications
You must be signed in to change notification settings - Fork 909
feat: implement vite package bundler and fix previous webpack config #1322
Conversation
add |
Kinda sorta works at this point, but the service worker is broken, and that's breaking a lot of things in turn. Going to try some of what's in here: https://vite-plugin-pwa.netlify.app/guide/inject-manifest.html#custom-service-worker |
adjusted the name of the PR to something more descriptive of what you're doing, now you can |
@0-vortex I can reproduce the error locally with |
our .babelrc might have something to do with it as well! |
So far it doesn’t appear to be an issue with the service worker (anymore), and at the moment the error seems to be somewhere in or near the react markdown component we use. |
Hope this is not a longshot but that honestly sounds much more reasonable, we might get some help around that by searching for the rollup keyword and our failing component :D |
This appears to be most likely related: cc @ajcwebdev since I know you were looking at this also. |
ci: cloud providers integration
LGTM! 👍 some minor improvement chores we can open issues for but keen to get this in 2021 still 🍕 |
@bdougie any chance you can check out this new technique? |
🎉 This PR is included in version 0.42.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
What type of PR is this? (check all applicable)
Description
One could argue this closes #1131 😝 I managed to get things running in like 25 minutes because it had so many steps in common with PR #1320 💨
Related Tickets & Documents
closes #1346
Mobile & Desktop Screenshots/Recordings
Added tests?
Added to documentation?
[optional] Are there any post-deployment tasks we need to perform?
Pssh probably
[optional] What gif best describes this PR or how it makes you feel?