Skip to content
This repository has been archived by the owner on May 25, 2023. It is now read-only.

feat: implement vite package bundler and fix previous webpack config #1322

Merged
merged 67 commits into from
Dec 31, 2021

Conversation

mtfoley
Copy link
Contributor

@mtfoley mtfoley commented Dec 1, 2021

What type of PR is this? (check all applicable)

  • ♻️ Refactor
  • ✨ Feature
  • 🐛 Bug Fix
  • 👷 Optimization
  • 📝 Documentation Update
  • 🔖 Release
  • 🚩 Other

Description

One could argue this closes #1131 😝 I managed to get things running in like 25 minutes because it had so many steps in common with PR #1320 💨

Related Tickets & Documents

closes #1346

Mobile & Desktop Screenshots/Recordings

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help

Added to documentation?

  • 📜 readme
  • 📜 contributing.md
  • 📓 docs
  • 📕 storybook
  • 🙅 no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

Pssh probably

[optional] What gif best describes this PR or how it makes you feel?

sonic

@mtfoley mtfoley changed the title Feature: Implement Vite for bundling feat: Implement Vite for bundling Dec 1, 2021
@0-vortex
Copy link
Contributor

0-vortex commented Dec 1, 2021

add closes # somewhere :D

@mtfoley mtfoley changed the title feat: Implement Vite for bundling feat: Implement Vite for bundling (WIP) Dec 1, 2021
@mtfoley
Copy link
Contributor Author

mtfoley commented Dec 1, 2021

Kinda sorta works at this point, but the service worker is broken, and that's breaking a lot of things in turn. Going to try some of what's in here: https://vite-plugin-pwa.netlify.app/guide/inject-manifest.html#custom-service-worker

@0-vortex 0-vortex changed the title feat: Implement Vite for bundling (WIP) feat: implement vite package bundler and fix previous webpack config Dec 2, 2021
@0-vortex
Copy link
Contributor

0-vortex commented Dec 2, 2021

adjusted the name of the PR to something more descriptive of what you're doing, now you can closes # the webpack issue 🍕

@mtfoley
Copy link
Contributor Author

mtfoley commented Dec 10, 2021

@0-vortex I can reproduce the error locally with node node_modules/vite/bin/vite.js preview after running a build. Per your suggestion, I tried this with https://github.com/vitejs/vite/tree/main/packages/plugin-react and it was even more messed up. I'm going to see if I can isolate a problematic component for now.

@0-vortex
Copy link
Contributor

our .babelrc might have something to do with it as well!

@mtfoley
Copy link
Contributor Author

mtfoley commented Dec 11, 2021

So far it doesn’t appear to be an issue with the service worker (anymore), and at the moment the error seems to be somewhere in or near the react markdown component we use.

@0-vortex
Copy link
Contributor

So far it doesn’t appear to be an issue with the service worker (anymore), and at the moment the error seems to be somewhere in or near the react markdown component we use.

Hope this is not a longshot but that honestly sounds much more reasonable, we might get some help around that by searching for the rollup keyword and our failing component :D

@mtfoley
Copy link
Contributor Author

mtfoley commented Dec 13, 2021

So far it doesn’t appear to be an issue with the service worker (anymore), and at the moment the error seems to be somewhere in or near the react markdown component we use.

This appears to be most likely related:
vitejs/vite#3592

cc @ajcwebdev since I know you were looking at this also.

@0-vortex
Copy link
Contributor

LGTM! 👍

some minor improvement chores we can open issues for but keen to get this in 2021 still 🍕

@0-vortex
Copy link
Contributor

@bdougie any chance you can check out this new technique?

@0-vortex 0-vortex merged commit eb1bb90 into open-sauced:main Dec 31, 2021
github-actions bot pushed a commit that referenced this pull request Dec 31, 2021
## [0.42.0](v0.41.1...v0.42.0) (2021-12-31)

### 🍕 Features

* implement vite package bundler and fix previous webpack config ([#1322](#1322)) ([eb1bb90](eb1bb90)), closes [#1346](#1346)
@github-actions
Copy link
Contributor

🎉 This PR is included in version 0.42.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

bdougie pushed a commit that referenced this pull request Apr 1, 2022
## [0.42.0](v0.41.1...v0.42.0) (2021-12-31)

### 🍕 Features

* implement vite package bundler and fix previous webpack config ([#1322](#1322)) ([eb1bb90](eb1bb90)), closes [#1346](#1346)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: investigate vite-plugin-pwa for workbox Feature: webpack 5 dependency updates
2 participants