This repository has been archived by the owner on May 25, 2023. It is now read-only.
feat: update create-react-app base to 5 and correct tooling issues #1342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdougie
reviewed
Dec 19, 2021
bdougie
reviewed
Dec 19, 2021
| @@ -26,7 +26,7 @@ function Repository({user, match}) { | |||
| } = match; | |||
| const [repository, setRepository] = useState(null); | |||
| const [error, setError] = useState(null); | |||
| const [note, setNote] = useState(location.note); | |||
| const [note, setNote] = useState(null); | |||
There was a problem hiding this comment.
Curious about this as well. Does this solve an error that was overlooked?
There was a problem hiding this comment.
I’ve made this adjustment offline in the vite branch in response to some errors. but haven’t committed or pushed. I don’t know what location.note Referred to but being that it was the prefetch state value something “empty” makes sense to have here.
There was a problem hiding this comment.
location.note was never really populated - that key doesn't exist in the location object
|
@bdougie this was missing some commits :D I'll cancel the release flow and re-open if that's ok 🍕 |
0-vortex
added a commit
to 0-vortex/open-sauced
that referenced
this pull request
Dec 20, 2021
…-5-webpack-5 * origin/main: feat: update create-react-app base to 5 and correct tooling issues (open-sauced#1342)
github-actions bot
pushed a commit
that referenced
this pull request
Dec 20, 2021
## [0.41.0](v0.40.2...v0.41.0) (2021-12-20) ### 🍕 Features * update create-react-app base to 5 and correct tooling issues ([#1342](#1342)) ([d30044c](d30044c)) ### 🐛 Bug Fixes * update create-react-app base to 5 and correct tooling issues ([#1344](#1344)) ([0fee440](0fee440)), closes [#1131](#1131) [#1343](#1343)
0-vortex
added a commit
to mtfoley/open-sauced
that referenced
this pull request
Dec 20, 2021
* origin/main: chore(minor): release 0.41.0 [skip ci] fix: update create-react-app base to 5 and correct tooling issues (open-sauced#1344) feat: update create-react-app base to 5 and correct tooling issues (open-sauced#1342) chore(deps-dev): bump postcss-preset-env from 7.0.1 to 7.0.2 (open-sauced#1338) chore(patch): release 0.40.2 [skip ci] fix: correct docker build (open-sauced#1335) build: update deps and semantic release (open-sauced#1333)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
This PR does a bunch of things:
Related Tickets & Documents
closes #1131
Mobile & Desktop Screenshots/Recordings
Added tests?
Added to documentation?
[optional] Are there any post-deployment tasks we need to perform?
[optional] What gif best describes this PR or how it makes you feel?