This repository has been archived by the owner on May 25, 2023. It is now read-only.
fix(onboarding-broke): new user onboarding was broken, sort of #1412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems to work fine on new user: |
github-actions bot
pushed a commit
that referenced
this pull request
Apr 2, 2022
### [0.44.1](v0.44.0...v0.44.1) (2022-04-02) ### 🐛 Bug Fixes * **onboarding-broke:** new user onboarding was broken, sort of ([#1412](#1412)) ([52eb2b5](52eb2b5))
|
🎉 This PR is included in version 0.44.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
This PR fixes the issue with new users unable to create goals repos. Turns out when a repo does not exist, the ternary was only checking for an error and this is technically not an error.
Related Tickets & Documents
fixes #1411
Mobile & Desktop Screenshots/Recordings
Added tests?
Added to documentation?
[optional] Are there any post-deployment tasks we need to perform?
[optional] What gif best describes this PR or how it makes you feel?