Skip to content
This repository has been archived by the owner on May 25, 2023. It is now read-only.

feat: Adds Repo suggestions to the onboarding flow #1444

Merged
merged 14 commits into from
May 24, 2022
Merged

feat: Adds Repo suggestions to the onboarding flow #1444

merged 14 commits into from
May 24, 2022

Conversation

chadstewart
Copy link
Contributor

@chadstewart chadstewart commented May 21, 2022 •
edited

What type of PR is this? (check all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🎨 Style
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build
  • 🔁 CI
  • 📦 Chore (Release)
  • ⏩ Revert

Description

This PR adds the feature of repo suggestions in onboarding.

Related Tickets & Documents

Adds #1428

Mobile & Desktop Screenshots/Recordings

Screenshot from 2022-05-23 20-06-28
Screenshot from 2022-05-23 20-06-41
Screenshot from 2022-05-23 17-31-04

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help

Added to documentation?

  • 📜 README.md
  • 📓 docs.opensauced.pizza
  • 🍕 dev.to/opensauced
  • 📕 storybook
  • 🙅 no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

@chadstewart chadstewart changed the title Official start of working on this feature. feat: Adds Repo suggestions to the onboarding flow May 21, 2022
@chadstewart
Disabled Tooltip trigger when the step isn't highlighted.
93fd0c5
@chadstewart
Added hard coded repo listing to onboarding.
9e4c1ce
@chadstewart
Started process of adding navbar for selecting the different listed r…
89ccee3 
…epos.
@chadstewart
Updated add repos component to be able to cycle through repos.
85e48c5
@chadstewart
App only allows someone to dashboard if they've added at least one repo.
d8ebe49
@chadstewart
Everything is properly disabled when all the other steps are completed.
f72d2f1
@chadstewart
Updated so that only on database creation that the add repo component…
4a69fa2 
… will be viewable.
@chadstewart
Changed add repo nav to be column at tablet and smaller screen sizes.
43a0cad
@chadstewart
Added the ability to add repos from the create goals component throug…
88763b1 
…h a rough implementation.
@chadstewart
Added very basic validation for add repo button.
bb4f11d
@chadstewart
Added actual buttons to add repo nav and changed repos in list.
452d95c
@chadstewart
Added updated Create Goals component to storybook.
cc58b1d
@chadstewart chadstewart requested a review from bdougie May 23, 2022 22:37
@chadstewart chadstewart marked this pull request as ready for review May 23, 2022 22:37
bdougie
bdougie suggested changes May 24, 2022
View reviewed changes
Copy link
Member

@bdougie bdougie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. We can lose the girl in mobile view
  2. Left align buttons and text (especially in mobile)
  3. Always use the fullName - i.e. open-sauced/open-sauced. Use doesn't know what cli is.

@bdougie
Copy link
Member

bdougie commented May 24, 2022

  • Left align buttons and text (especially in mobile)

On second thought this should 💯 be left aligned but also, each button should be on the same line and have a natural break for screen width.

github-actions[bot]
github-actions bot reviewed May 24, 2022
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks

Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.

Issue Reference

In order to be considered for merging, the pull request description must refer to a specific issue number. This is described in our Contributing Guide.
This check is looking for a phrase similar to: "Fixes #XYZ" or "Resolves #XYZ" where XYZ is the issue number that this PR is meant to address.

@chadstewart
Copy link
Contributor Author

  1. We can lose the girl in mobile view
  2. Left align buttons and text (especially in mobile)
  3. Always use the fullName - i.e. open-sauced/open-sauced. Use doesn't know what cli is.

Made those changes you requested @bdougie!

@chadstewart chadstewart requested a review from bdougie May 24, 2022 01:25
bdougie
bdougie approved these changes May 24, 2022
View reviewed changes
Copy link
Member

@bdougie bdougie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for now. Going to merge for the sake of moving on.

@bdougie bdougie merged commit 507e047 into main May 24, 2022
@bdougie bdougie deleted the feature-1428-onboarding-repo-suggestions branch May 24, 2022 13:47
github-actions bot pushed a commit that referenced this pull request May 24, 2022
@bdougie
feat: Adds Repo suggestions to the onboarding flow (#1444) 507e047
d716ff2
github-actions bot pushed a commit that referenced this pull request May 24, 2022
@chadstewart @open-sauced
chore(minor): release 0.52.0 [skip ci]
4a26b94 
## [0.52.0](v0.51.0...v0.52.0) (2022-05-24)

### 🍕 Features

* Adds Repo suggestions to the onboarding flow ([#1444](#1444)) ([507e047](507e047))
@github-actions
Copy link
Contributor

🎉 This PR is included in version 0.52.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@chadstewart chadstewart mentioned this pull request May 29, 2022
Closed
2 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@github-actions github-actions[bot] github-actions left review comments

@bdougie bdougie bdougie approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@chadstewart @bdougie