Skip to content
This repository has been archived by the owner on May 25, 2023. It is now read-only.

fix: Patch release-management.yml (testing if this works) #945

Merged
merged 2 commits into from
Apr 28, 2021

Conversation

bdougie
Copy link
Member

@bdougie bdougie commented Apr 28, 2021

What type of PR is this? (check all applicable)

  • ♻️ Refactor
  • ✨ Feature
  • 🐛 Bug Fix
  • 👷 Optimization
  • 📝 Documentation Update
  • 🔖 Release
  • 🚩 Other

Description

Related Tickets & Documents

The npm run release is not committing to package.json update. Testing if this action will update it.

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help

Added to documentation?

  • 📜 readme
  • 📜 contributing.md
  • 🙅 no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

@bdougie bdougie changed the title Patch release-management.yml (testing if this works) fix: Patch release-management.yml (testing if this works) Apr 28, 2021
@bdougie bdougie mentioned this pull request Apr 28, 2021
13 tasks
@@ -119,7 +119,7 @@
"build-storybook": "build-storybook --no-dll",
"lint": "eslint .",
"lint:fix": "eslint --fix --ext .js,.jsx .",
"release": "standard-version"
"release": "standard-version --tag-prefix="
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

release drafter is already creating tags. This will skip tags for standard release and hopefully grab the latest tag.

@bdougie bdougie merged commit 33224c8 into main Apr 28, 2021
@bdougie bdougie deleted the patch-npm-release branch April 28, 2021 15:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant