Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: better compose digital ocean config variables #18

Closed
3 of 13 tasks
0-vortex opened this issue Apr 6, 2023 · 2 comments
Closed
3 of 13 tasks

feature: better compose digital ocean config variables #18

0-vortex opened this issue Apr 6, 2023 · 2 comments
Labels
💡 feature released on @beta released

Comments

@0-vortex
Copy link
Contributor

0-vortex commented Apr 6, 2023

Type of feature

Select the type of feature request, the lowercase should also be the PR prefix.

  • 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🎨 Style
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build
  • 🔁 CI
  • 📦 Chore (Release)
  • ⏩ Revert

Current behavior

We are not building the CDN S3 URL correctly, as we are using the aws-sdk region value of us-east-1 as a configurable variable instead of the default.

Suggested solution

The current region should be sfo3 and our config should be adjusted and generateFileUrl should also change to account for different types of domains based on current envs but also custom domains we are planning for in #17

Code of Conduct

By submitting this issue, you agree to follow our Code of Conduct.

  • I agree to follow this project's Code of Conduct

Contributing Docs

If you plan on contributing code please read - Contribution Guide

  • I agree to follow this project's Contribution Docs
@0-vortex 0-vortex mentioned this issue Apr 6, 2023
Merged
3 tasks
github-actions bot pushed a commit that referenced this issue Apr 8, 2023
@0-vortex @open-sauced
chore(minor): release 1.2.0-beta.4 on beta channel [skip ci]
d542b0c 
## [1.2.0-beta.4](v1.2.0-beta.3...v1.2.0-beta.4) (2023-04-08)

### 🍕 Features

* add custom cdn endpoint configuration for s3 bucket on digital ocean ([077e473](077e473)), closes [#18](#18)
@github-actions
Copy link

github-actions bot commented Apr 8, 2023

🎉 This issue has been resolved in version 1.2.0-beta.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

github-actions bot pushed a commit that referenced this issue Apr 8, 2023
@0-vortex
feat: add custom cdn endpoint configuration for s3 bucket on digital …
0caf64f 
…ocean

closes #18 077e473
github-actions bot pushed a commit that referenced this issue Apr 11, 2023
@0-vortex @open-sauced
chore(major): release 2.0.0 [skip ci]
49d0351 
## [2.0.0](v1.1.2...v2.0.0) (2023-04-11)

### ⚠ BREAKING CHANGES

* id changed to :username in earlier commits, this is catching it up

### 🔁 Continuous Integration

* correct live release url in github actions deployment ([4a434e6](4a434e6))

### 🎨 Styles

* add tailwind proof of concept ([8594508](8594508))

### 📝 Documentation

* update live environments lins and document local development ([08cead1](08cead1))

### 🍕 Features

* add boilerplate s3-client sdk code connected to digital ocean spaces ([a4a71e3](a4a71e3))
* add custom cdn endpoint configuration for s3 bucket on digital ocean ([077e473](077e473)), closes [#18](#18)
* implement digital ocean spaces s3 client storage and cache images 3 days ([792992e](792992e))
* implement no-content verification strategy ([6efe0e6](6efe0e6))
* optimize image loading and return errors ([7c6f199](7c6f199)), closes [#17](#17)

### 🐛 Bug Fixes

* correct all tailwind classes except gaps ([fe44711](fe44711)), closes [#7](#7)
* correct app spec GET automatic rewrites of HEAD ([3047cec](3047cec))
* correct dark logo render and make it static ([dc9f3a4](dc9f3a4))
* correct languages displaying less than 0.5% ([bee0e6e](bee0e6e))
* correct server generation environment ([68d0202](68d0202))
* correct user languages sizing issues ([5846c42](5846c42))
* correct username display instead of full name ([1454cbb](1454cbb)), closes [#11](#11)
* correct yoga layout double styling, remove repo icon extrenaous classes ([d84015b](d84015b))
* correct zero contribution top repos language distribution ([7d82c0d](7d82c0d))

### 🤖 Build System

* update dependencies and ts5 ([715e349](715e349))
* update graphql types ([f7db713](f7db713))
@github-actions
Copy link

🎉 This issue has been resolved in version 2.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
💡 feature released on @beta released
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@0-vortex