Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: include LICENSE.md to denote a license for this project #5

Closed
2 tasks done
jpmcb opened this issue Jul 25, 2023 · 2 comments 路 Fixed by #6
Closed
2 tasks done

Feature: include LICENSE.md to denote a license for this project #5

jpmcb opened this issue Jul 25, 2023 · 2 comments 路 Fixed by #6

Comments

@jpmcb
Copy link
Member

jpmcb commented Jul 25, 2023

Type of feature

馃崟 Feature

Current behavior

There's currently no license or attribution.

Suggested solution

We'll need a license before we merge in #1 - cc @bdougie for your preference of license on this project. My gut is probably a permissive MIT license since we'll be using other open source, permissive ML models.

Additional context

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct

Contributing Docs

  • I agree to follow this project's Contribution Docs
@bdougie
Copy link
Member

bdougie commented Jul 25, 2023

Yes, MIT is ideal since we don't own a trademark on repo-query which is why we'd want to do Apache. The alternative is ISC, which we use in catsup. But MIT is fine.

One thing I wanted to ask but I haven't dug in. Are we omitting projects that don't have a license or a permissable license at least? If not, we should track that as a needed launch feature.

@jpmcb
Copy link
Member Author

jpmcb commented Jul 25, 2023

Are we omitting projects that don't have a license or a permissable license at least? If not, we should track that as a needed launch feature.

Good question: I don't believe so. Certain files are ignored (like node_modules, etc.) but we'll need to add the feature to ignore repos that do not have a permissible license. I'll make an issue for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants