Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to use array suffixes in JSON reform files #1505

Merged
merged 6 commits into from
Aug 10, 2017
Merged

Add ability to use array suffixes in JSON reform files #1505

merged 6 commits into from
Aug 10, 2017

Conversation

martinholmer
Copy link
Collaborator

@martinholmer martinholmer commented Aug 9, 2017

This pull request, which follows up #1503, implements the idea suggested by @talumbau in TaxBrain issue 596. This Tax-Calculator enhancement should enable a major simplification in TaxBrain logic and the elimination of at least one TaxBrain bug (the one discussed in issue 596).

See the three new test_translate_json_reform_suffixes_* test in the test_calculate.py file for details on how this enhancement can be used. The new capability is optional in the sense that all old JSON reform files continue to work as they did before. The new optional capability is meant primarily for TaxBrain, but could be used in hand-written JSON reform files.

@MattHJensen @feenberg @Amy-Xu @andersonfrailey @hdoupe @GoFroggyRun @codykallen
@talumbau @PeterDSteinberg @brittainhard

@codecov-io
Copy link

codecov-io commented Aug 9, 2017

Codecov Report

Merging #1505 into master will increase coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1505      +/-   ##
==========================================
+ Coverage   99.92%   99.96%   +0.04%     
==========================================
  Files          37       37              
  Lines        2507     2553      +46     
==========================================
+ Hits         2505     2552      +47     
+ Misses          2        1       -1
Impacted Files Coverage Δ
taxcalc/calculate.py 100% <100%> (ø) ⬆️
taxcalc/policy.py 100% <100%> (+1.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f86ba1...660a3ca. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants