Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-instrumentation support for okhttp3 http requests #47

Closed
surbhiia opened this issue Aug 25, 2023 · 8 comments
Closed

Auto-instrumentation support for okhttp3 http requests #47

surbhiia opened this issue Aug 25, 2023 · 8 comments

Comments

@surbhiia
Copy link
Contributor

surbhiia commented Aug 25, 2023

Currently, manual instrumentation of okhttp3 and volleyHttp clients is supported. It requires app developers to call a specific api to get the instrumented http client to avail the instrumentation. Adding this issue to capture the requirement for auto-instrumentation of network requests. Two clients we think auto-instrumentation should be supported for are - OkHttp3 and HttpURLConnection.

Others reading this, do comment what http clients you think are most commonly used today and should be supported.

@breedx-splk
Copy link
Contributor

@surbhiia Can we rename this to be just http specific? Network is much much broader, and I like the idea of starting with http.

@surbhiia surbhiia changed the title Auto-instrumentation support for network requests Auto-instrumentation support for http requests Sep 5, 2023
@surbhiia
Copy link
Contributor Author

surbhiia commented Sep 6, 2023

Updated issue title! I'm also working on creating a POC for HttpURLConnection auto-instrumentation using byte buddy android plugin.

@breedx-splk
Copy link
Contributor

@surbhiia Take a look at #64 and let's make sure that we're not duplicating efforts. 😃

@surbhiia
Copy link
Contributor Author

surbhiia commented Sep 7, 2023

Yes! Thanks for pointing that out. I had a chat with @LikeTheSalad last week about this. :) HttpURLConnection plugin would be an additional byte buddy plugin like the okhttp3 one in #64 and I will leverage all the base setup done in that PR.

@breedx-splk
Copy link
Contributor

I think it would be great now to close this and to split into new auto-instrumentation enhancement issues, 1 for HttpUrlConnection and 1 for Volley.

@surbhiia
Copy link
Contributor Author

surbhiia commented Oct 4, 2023

That'd be better yes! Closing this and creating two new ones. :)

@surbhiia surbhiia closed this as completed Oct 4, 2023
@surbhiia surbhiia changed the title Auto-instrumentation support for http requests Auto-instrumentation support for okhttp3 http requests Oct 4, 2023
@surbhiia
Copy link
Contributor Author

surbhiia commented Oct 4, 2023

Created issues #104 and #105!

@breedx-splk
Copy link
Contributor

Great, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants