-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auto-instrumentation support for okhttp3 http requests #47
Comments
@surbhiia Can we rename this to be just http specific? Network is much much broader, and I like the idea of starting with http. |
Updated issue title! I'm also working on creating a POC for HttpURLConnection auto-instrumentation using byte buddy android plugin. |
Yes! Thanks for pointing that out. I had a chat with @LikeTheSalad last week about this. :) HttpURLConnection plugin would be an additional byte buddy plugin like the okhttp3 one in #64 and I will leverage all the base setup done in that PR. |
I think it would be great now to close this and to split into new auto-instrumentation enhancement issues, 1 for HttpUrlConnection and 1 for Volley. |
That'd be better yes! Closing this and creating two new ones. :) |
Great, thanks! |
Currently, manual instrumentation of okhttp3 and volleyHttp clients is supported. It requires app developers to call a specific api to get the instrumented http client to avail the instrumentation. Adding this issue to capture the requirement for auto-instrumentation of network requests. Two clients we think auto-instrumentation should be supported for are - OkHttp3 and HttpURLConnection.
Others reading this, do comment what http clients you think are most commonly used today and should be supported.
The text was updated successfully, but these errors were encountered: