SimpleNetworkDetector uses deprecated APIs

[breedx-splk]

There is a build warning about the SimpleNetworkDetector using deprecated APIs. I believe that this is specifically related to the use of NetworkInfo and some of the methods (see the comments in SimpleNetworkDetector).

The Elastic android instrumentation seems to agree with a long-lived stackoverflow post about how to mitigate this.

Although things are probably still working, it would be nice to migrate to a more sophisticated/robust solution going forward.

[breedx-splk]

Then again, because the SimpleNetworkDetector is really only wired up in older SDKs, suppressing the warning might be appropriate.

[LikeTheSalad]

There was an important API addition in the way Android provides a "default" network connectivity info on API 24 that makes this a lot easier, which is the one we use in the Elastic agent. I think it's worth waiting on the outcome of open-telemetry/opentelemetry-java#5936 before adding any further changes to SimpleNetworkDetector or to the overall network detection mechanism.

[LikeTheSalad]

As a side note, it seems like the overall network detection process is started here, although I can't find where this function is called, so I'm wondering if this is currently dead code @breedx-splk?

[breedx-splk]

As a side note, it seems like the overall network detection process is started here, although I can't find where this function is called, so I'm wondering if this is currently dead code @breedx-splk?

It's been a public method on a public class, so users can use it how they please. In the original Splunk code, it was called by the RumInitializer. Now with #121, it's called based on the config value, which defaults to true.

[LikeTheSalad]

Ah, got it! I missed it in your PR. Cheers.