Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split OTLP -> Loki conversion logic into its own package #13649

Closed
jpkrohling opened this issue Aug 26, 2022 · 2 comments
Closed

Split OTLP -> Loki conversion logic into its own package #13649

jpkrohling opened this issue Aug 26, 2022 · 2 comments
Assignees
@jpkrohling
Labels
comp:grafanalabs Grafana Labs components - Loki, Grafana exporter/loki Loki Exporter priority:needed Triagers reviewed the issue but need code owner to set priority Stale

Comments

@jpkrohling
Copy link
Member

To unify the conversion logic between OTLP and Loki on the OpenTelemetry Collector and Loki, we should split this into its package, similar to what we have for the Jaeger translator. This should be done following up on #12873.
@jpkrohling jpkrohling added comp:grafanalabs Grafana Labs components - Loki, Grafana exporter/loki Loki Exporter labels Aug 26, 2022
@jpkrohling jpkrohling self-assigned this Aug 26, 2022
@evan-bradley evan-bradley added the priority:needed Triagers reviewed the issue but need code owner to set priority label Sep 9, 2022
@github-actions
Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Nov 10, 2022
@mar4uk
Copy link
Contributor

mar4uk commented Nov 10, 2022 •
edited

pkg/translator/loki was created #14106. This issue could be closed

@mar4uk mar4uk mentioned this issue Nov 11, 2022
Merged
@mx-psi mx-psi closed this as completed Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jpkrohling jpkrohling

Labels
comp:grafanalabs Grafana Labs components - Loki, Grafana exporter/loki Loki Exporter priority:needed Triagers reviewed the issue but need code owner to set priority Stale
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jpkrohling @mar4uk @mx-psi @evan-bradley