[receiver/elasticsearchreceiver] Fix client request nodeStatsPath to collect supported metrics

[JonathanWamsley]

Describe the bug
When metrics where added, a mock was done correctly but the client request path were never updated.

opentelemetry-collector-contrib/receiver/elasticsearchreceiver/client.go

Lines 85 to 88 in db6987e

	const nodeStatsMetrics = "breaker,indices,process,jvm,thread_pool,transport,http,fs,indexing_pressure,ingest,indices,adaptive_selection,discovery"
	// nodeStatsIndexMetrics is a comma separated list of index metrics that will be gathered from NodeStats.
	const nodeStatsIndexMetrics = "store,docs,indexing,get,search,merge,refresh,flush,warmer,query_cache,fielddata"

os, script should be added to the nodeStatsMetrics

opentelemetry-collector-contrib/receiver/elasticsearchreceiver/internal/model/nodestats.go

Lines 25 to 40 in db6987e

	type NodeStatsNodesInfo struct {
	TimestampMsSinceEpoch int64 `json:"timestamp"`
	Name string `json:"name"`
	Indices NodeStatsNodesInfoIndices `json:"indices"`
	ProcessStats ProcessStats `json:"process"`
	JVMInfo JVMInfo `json:"jvm"`
	ThreadPoolInfo map[string]ThreadPoolStats `json:"thread_pool"`
	TransportStats TransportStats `json:"transport"`
	HTTPStats HTTPStats `json:"http"`
	CircuitBreakerInfo map[string]CircuitBreakerStats `json:"breakers"`
	FS FSStats `json:"fs"`
	OS OSStats `json:"os"`
	IndexingPressure IndexingPressure `json:"indexing_pressure"`
	Discovery Discovery `json:"discovery"`
	Ingest Ingest `json:"ingest"`
	Script Script `json:"script"`

translog should be included in the nodeStatsIndexMetrics

opentelemetry-collector-contrib/receiver/elasticsearchreceiver/internal/model/nodestats.go

Lines 166 to 178 in db6987e

	type NodeStatsNodesInfoIndices struct {
	StoreInfo StoreInfo `json:"store"`
	DocumentStats DocumentStats `json:"docs"`
	IndexingOperations IndexingOperations `json:"indexing"`
	GetOperation GetOperation `json:"get"`
	SearchOperations SearchOperations `json:"search"`
	MergeOperations BasicIndexOperation `json:"merges"`
	RefreshOperations BasicIndexOperation `json:"refresh"`
	FlushOperations BasicIndexOperation `json:"flush"`
	WarmerOperations BasicIndexOperation `json:"warmer"`
	QueryCache BasicCacheInfo `json:"query_cache"`
	FieldDataCache BasicCacheInfo `json:"fielddata"`
	TranslogStats TranslogStats `json:"translog"`

This can be seen in the 7.16 integration test that was recently updated for the following metric paths:

• os
  Example of a metric that should be non-zero:
  

  opentelemetry-collector-contrib/receiver/elasticsearchreceiver/testdata/integration/expected.7_16_3.json

  Lines 4841 to 4847 in db6987e

  	"asDouble": 0,
  	"startTimeUnixNano": "1662563239984708000",
  	"timeUnixNano": "1662563249986155000"
  	}
  	]
  	},
  	"name": "elasticsearch.os.cpu.load_avg.15m",

• script
  Example of a metric that should be non-zero:
  

  opentelemetry-collector-contrib/receiver/elasticsearchreceiver/testdata/integration/expected.7_16_3.json

  Lines 1675 to 1680 in db6987e

  	"name": "elasticsearch.node.script.compilations",
  	"sum": {
  	"aggregationTemporality": "AGGREGATION_TEMPORALITY_CUMULATIVE",
  	"dataPoints": [
  	{
  	"asInt": "0",

• translog
  Example of a metric that should be non-zero:
  

  opentelemetry-collector-contrib/receiver/elasticsearchreceiver/testdata/integration/expected.7_16_3.json

  Lines 4808 to 4813 in db6987e

  	"name": "elasticsearch.node.translog.size",
  	"sum": {
  	"aggregationTemporality": "AGGREGATION_TEMPORALITY_CUMULATIVE",
  	"dataPoints": [
  	{
  	"asInt": "0",

Steps to reproduce
Running ES or integration test and observing zero metric values for said metrics.

What did you expect to see?
In the client request, the above metric paths.

What did you see instead?
In the client request, the above metric paths missing os, script and translog.
This can be easily observed with the zero metric values in the integration test.

What version did you use?
elasticsearchreceiver v0.59.0

[JonathanWamsley]

@djaglowski Is one PR good or would you prefer 3 different PR's for the os , script and translog separately?

[djaglowski]

@JonathanWamsley, separate please

[JonathanWamsley]

Resolved with #13985 #13986 and #13988