Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[receiver/hostmetrics/disk] When running on windows, receiver crashes collector when perf counter is unavailable #14032

Closed
djaglowski opened this issue Sep 12, 2022 · 4 comments · Fixed by #14164
Labels
bug Something isn't working priority:p2 Medium receiver/hostmetrics

Comments

@djaglowski
Copy link
Member

djaglowski commented Sep 12, 2022

Describe the bug
Running on Windows, the collector fails to start up if the "LogicalDisk" performance counter is not available.

Steps to reproduce
Run collector w/ a user that does not have access to the performance counter. (User belongs to neither Administrators nor Performance Monitor Users group.)

What did you expect to see?
The collector should start up successfully and run. The scraper should return an error from the scraper funciton.

What version did you use?
Windows 10

Additional context
Although this error may be essentially permanent, I do not believe it should cause the collector to crash during startup because this pattern causes the collector to be fragile. To illustrate the point, consider a collector that runs 20 scrapers, each of which may crash the collector during startup if their respective target is not available.

@djaglowski djaglowski added the bug Something isn't working label Sep 12, 2022
@djaglowski
Copy link
Member Author

cc @dmitryax

@djaglowski
Copy link
Member Author

The load and paging scrapers also appear to error during start, if an expected counter is not available.

@github-actions
Copy link
Contributor

Pinging code owners: @dmitryax. See Adding Labels via Comments if you do not have permissions to add labels yourself.

@BinaryFissionGames
Copy link
Contributor

I can take a look into this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority:p2 Medium receiver/hostmetrics
Projects
None yet
3 participants