Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[processor/servicegraphprocessor] Adjust metric names to fit documentation #14187

Closed
sarahsporck opened this issue Sep 19, 2022 · 4 comments
Closed
Assignees
Labels
bug Something isn't working priority:p2 Medium processor/servicegraph Service graph processor

Comments

@sarahsporck
Copy link

What happened?

## Description

In the documentation the metric names do not align with the actual names of the metrics, e.g. 'traces_service_graph_request_total' and 'request_total'

## Steps to Reproduce

## Expected Result

Metrics are prefixed with traces_service_graph

## Actual Result

Metrics are not prefixed

Collector version

v0.60.0

Environment information

No response

OpenTelemetry Collector configuration

receivers:
  otlp:
    protocols:
      grpc:

  otlp/servicegraph:
    protocols:
      grpc:
        endpoint: "localhost:12345"

processors:    
  servicegraph:
    metrics_exporter: prometheus

exporters:
  prometheus:
    endpoint: "0.0.0.0:8889"

  logging:
    logLevel: debug

service:
  pipelines:
    traces:
      receivers: [otlp]
      processors: [servicegraph]
      exporters: [logging]
    metrics:
      receivers: [otlp/servicegraph]
      exporters: [prometheus]

Log output

No response

Additional context

No response

@github-actions
Copy link
Contributor

Pinging code owners: @jpkrohling @mapno. See Adding Labels via Comments if you do not have permissions to add labels yourself.

@mapno
Copy link
Contributor

mapno commented Sep 20, 2022

Hi @sarahsporck, thanks for the report. This was an oversight. This PR addresses the problem

@sarahsporck
Copy link
Author

Ah, nice.
Didn't see that one.

@evan-bradley evan-bradley added priority:p2 Medium and removed needs triage New item requiring triage labels Sep 26, 2022
@mapno
Copy link
Contributor

mapno commented Sep 28, 2022

Can we close this issue? This PR fixed the problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority:p2 Medium processor/servicegraph Service graph processor
Projects
None yet
Development

No branches or pull requests

5 participants