Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pkg/stanza/adapter] Unused Convert helper #17429

Closed
dmitryax opened this issue Jan 7, 2023 · 6 comments · Fixed by #18259
Closed

[pkg/stanza/adapter] Unused Convert helper #17429

dmitryax opened this issue Jan 7, 2023 · 6 comments · Fixed by #18259
Labels
bug Something isn't working needs triage New item requiring triage pkg/stanza

Comments

@dmitryax
Copy link
Member

dmitryax commented Jan 7, 2023 •
edited
Loading

Convert helper was introduced in #3125. It was expected to be used in tests but was never used.

Now we have pkg/stanza/adapter exposed as a public API, it's important to limit its scope.
@dmitryax dmitryax added bug Something isn't working needs triage New item requiring triage labels Jan 7, 2023
@dmitryax
Copy link
Member Author

dmitryax commented Jan 7, 2023

@djaglowski I see your comment but don't understand how the Convert function can help there. Please let me know if I'm missing something.

If this function isn't needed, I suggest deprecating it to see if other distros use it. WDYT?

@djaglowski
Copy link
Member

I think it's ok to deprecate. It is used in our tests at least, but we can just move it into test code.

@dmitryax
Copy link
Member Author

dmitryax commented Jan 9, 2023 •
edited
Loading

@djaglowski Sounds good. Submitted a PR #17450, PTAL

@dmitryax dmitryax mentioned this issue Jan 10, 2023
Merged
@github-actions
Copy link
Contributor

Pinging code owners for pkg/stanza: @djaglowski. See Adding Labels via Comments if you do not have permissions to add labels yourself.

@djaglowski
Copy link
Member

@dmitryax, do you agree this can be closed?

@dmitryax dmitryax mentioned this issue Feb 2, 2023
Merged
@dmitryax
Copy link
Member Author

dmitryax commented Feb 2, 2023

@djaglowski #18259 will close it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working needs triage New item requiring triage pkg/stanza
Projects
None yet
Milestone
No milestone
3 participants
@djaglowski @dmitryax @fatsheep9146