Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[exporter/loki] Do not retry permanent errors #18059

Closed
wiardvanrij opened this issue Jan 26, 2023 · 6 comments
Closed

[exporter/loki] Do not retry permanent errors #18059

wiardvanrij opened this issue Jan 26, 2023 · 6 comments
Labels
bug Something isn't working exporter/loki Loki Exporter good first issue Good for newcomers

Comments

@wiardvanrij
Copy link
Contributor

Component(s)

exporter/loki

What happened?

Description

Legacy exporter has: https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/exporter/lokiexporter/legacy_exporter.go#L164

New exporter hasn't: https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/exporter/lokiexporter/next_exporter.go#L105

This is pretty painful on 400 requests, like has timestamp too old = http 400. Which causes a ton of retries.

Collector version

latest

Environment information

No response

OpenTelemetry Collector configuration

No response

Log output

No response

Additional context

No response

@wiardvanrij wiardvanrij added bug Something isn't working needs triage New item requiring triage labels Jan 26, 2023
@github-actions github-actions bot added the exporter/loki Loki Exporter label Jan 26, 2023
@github-actions
Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@jpkrohling
Copy link
Member

@wiardvanrij would you like to send a PR for this one?

@jpkrohling jpkrohling added the good first issue Good for newcomers label Jan 27, 2023
@wiardvanrij
Copy link
Contributor Author

Sure, I can take a look

@wiardvanrij
Copy link
Contributor Author

@jpkrohling thx! I was wondering what the release schedule is? We really would appreciate using this change asap as it now can potentially cause a lot of issues.

@jpkrohling
Copy link
Member

We release every two weeks, the next one on Feb 6th: https://github.com/open-telemetry/opentelemetry-collector/blob/main/docs/release.md#release-schedule

@jpkrohling
Copy link
Member

closed by #18083

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working exporter/loki Loki Exporter good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants