Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[connectors/spanmetrics] Drop Prometheus-specific metrics labels sanitization. #18678

Closed
kovrus opened this issue Feb 15, 2023 · 2 comments · Fixed by #18757
Closed

[connectors/spanmetrics] Drop Prometheus-specific metrics labels sanitization. #18678

kovrus opened this issue Feb 15, 2023 · 2 comments · Fixed by #18757
Assignees

Comments

@kovrus
Copy link
Member

kovrus commented Feb 15, 2023

Component(s)

connector/spanmetrics

Describe the issue you're reporting

Description

Remove Prometheus-specific labels sanitization.

The spanmeterics connector is the OTel component, therefore, we would like to strip Prometheus-specific parts from it. The label conversion to Prometheus conventions should happen in the Prometheus component, e.g. Prometheus remote write exporter (which is implemented already).

It is the change that will be done in the new (not yet enabled) component, so it does not break anything for the existing users. However, we have to inform users about these changes when migrating from spanmeterics processor to spanmeterics connector.

@kovrus kovrus added needs triage New item requiring triage connector/spanmetrics labels Feb 15, 2023
@github-actions
Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions
Copy link
Contributor

Pinging code owners for connector/spanmetrics: @albertteoh. See Adding Labels via Comments if you do not have permissions to add labels yourself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant