Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support MaxScale on spanmetrics using exponential histograms #22804

Closed
aptomaKetil opened this issue May 26, 2023 · 3 comments
Closed

Support MaxScale on spanmetrics using exponential histograms #22804

aptomaKetil opened this issue May 26, 2023 · 3 comments
Labels

Comments

@aptomaKetil
Copy link

Component(s)

connector/spanmetrics

Is your feature request related to a problem? Please describe.

The exponential histogram settings for the spanmetrics connector do not support the MaxScale parameter from the OTEL spec. This means you can't easily forward these to Prometheus, since they may have a scale above 8.

Describe the solution you'd like

Allow configuring the maximum scale factor.

Describe alternatives you've considered

Implement downscaling in the prometheusremotewrite translator.

Additional context

No response

@aptomaKetil aptomaKetil added enhancement New feature or request needs triage New item requiring triage labels May 26, 2023
@github-actions
Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions
Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

  • needs: Github issue template generation code needs this to generate the corresponding labels.
  • connector/spanmetrics: @albertteoh @kovrus

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions
Copy link
Contributor

This issue has been closed as inactive because it has been stale for 120 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Sep 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant