Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to add instrumentation scope name as a dimension #23662

Open
erri120 opened this issue Jun 24, 2023 · 7 comments
Open

Add option to add instrumentation scope name as a dimension #23662

erri120 opened this issue Jun 24, 2023 · 7 comments
Labels
connector/spanmetrics enhancement New feature or request never stale Issues marked with this label will be never staled and automatically removed

Comments

@erri120
Copy link

erri120 commented Jun 24, 2023

Component(s)

connector/spanmetrics

Is your feature request related to a problem? Please describe.

In my current project, I need the instrumentation scope name as a dimension in the exported span metrics.

Describe the solution you'd like

Ideally, a new option instrumentation_scope that allows you to configure which part of the scope should be included as a dimension:

spanmetrics:
  instrumentation_scope:
    name: true
    version: false

Additionally, dimensions should also look at the instrumentation scope attributes.

Describe alternatives you've considered

Alternative, I'd have to add the name of the instrumentation scope to the span's attributes before it's send to the collector and then use the dimensions option. This isn't ideal, since every span would now have an additional tag.

Additional context

No response

@erri120 erri120 added enhancement New feature or request needs triage New item requiring triage labels Jun 24, 2023
@github-actions
Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions
Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

  • needs: Github issue template generation code needs this to generate the corresponding labels.
  • connector/spanmetrics: @albertteoh

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Aug 24, 2023
@erri120
Copy link
Author

erri120 commented Aug 25, 2023

Still relevant, nothing has changed.

@crobert-1
Copy link
Member

This sounds like a valid request to me, we'd essentially just be copying instrumentation scope from the incoming traces to the scope of the outgoing metrics.

The configuration may need another look to match the style of existing options. It's usually something like include_ and exclude_. The current config also already has dimensions and exclude_dimensions so the difference would have to be clearly marked.

Are you interested in adding this enhancement?

@crobert-1 crobert-1 removed the needs triage New item requiring triage label Oct 24, 2023
Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Dec 25, 2023
@erri120
Copy link
Author

erri120 commented Dec 27, 2023

Still relevant, nothing has changed.

@github-actions github-actions bot removed the Stale label Dec 27, 2023
Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Feb 26, 2024
@crobert-1 crobert-1 added the never stale Issues marked with this label will be never staled and automatically removed label Feb 26, 2024
@crobert-1 crobert-1 removed the Stale label Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
connector/spanmetrics enhancement New feature or request never stale Issues marked with this label will be never staled and automatically removed
Projects
None yet
Development

No branches or pull requests

2 participants